fix: pointer eq #2627
Merged
fix: pointer eq #2627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petar-dambovaliev
requested review from
jaekwon,
moul,
piux2,
deelawn,
thehowl and
mvertes
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2627 +/- ##
==========================================
+ Coverage 54.99% 55.00% +0.01%
==========================================
Files 595 595
Lines 79775 79779 +4
==========================================
+ Hits 43872 43886 +14
+ Misses 32581 32575 -6
+ Partials 3322 3318 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
deelawn
reviewed
Jul 24, 2024
deelawn
approved these changes
Jul 25, 2024
thehowl
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes this
When comparing 2 upcasted pointers, if the types are not the same, they are not equal.