feat: precompile imports and fix gnodev test
#431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harry-hov
changed the title
gnodev testgnodev test
harry-hov
force-pushed
the
hariom/precompile-imports
branch
2 times, most recently
from
45aa668
to
517941f
Compare
harry-hov
changed the title
gnodev testgnodev test
harry-hov
force-pushed
the
hariom/precompile-imports
branch
from
f1a1583
to
517941f
Compare
zivkovicmilos
approved these changes
Dec 27, 2022
There was a problem hiding this comment.
I've left a few comments that need to be addressed, otherwise I think it looks alright 💯
I would've loved to have had more context in the PR description as to what this was fixing, and how it fixed the problem.
The PR didn't include a unit test that verified the problem and the fix, and also didn't include unit tests for introduced logic flows and helpers - we should start focusing on preventing future problems with good coverage
harry-hov
force-pushed
the
hariom/precompile-imports
branch
from
517941f
to
280447a
Compare
Now `gnodev precompile` and `gnodev test --precompile` support precompiling imports of the input file or package. - `gnodev precompile`: It is enabled by default. You need to pass addition flag `--skip-imports` to disable it. - `gnodev test --precompile` precompile imports automatically. Signed-off-by: Hariom Verma <hariom.verma@tendermint.com>
Fix error `cannot find package...` while running `gnodev test` by creating temporary go.mod file in the temporary root directory. Signed-off-by: Hariom Verma <hariom.verma@tendermint.com>
Try to find the nearest go.mod file, run `go build` in the same folder. Signed-off-by: Hariom Verma <hariom.verma@tendermint.com>
Currently, `stdlibs/stdshim` contains generated `*.gen.go` files. While other packages in the stdlibs contains `*.gno` files. Lets replace generated files with `*.gno` files. Signed-off-by: Hariom Verma <hariom.verma@tendermint.com>
Signed-off-by: Hariom Verma <hariom.verma@tendermint.com>
harry-hov
force-pushed
the
hariom/precompile-imports
branch
from
280447a
to
173897d
Compare
zivkovicmilos
approved these changes
Jan 9, 2023
Signed-off-by: Hariom Verma <hariom.verma@tendermint.com>
Signed-off-by: Hariom Verma <hariom.verma@tendermint.com>
moul
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Now
gnodev precompileandgnodev test --precompilesupport precompiling imports of the input file or package.gnodev precompile: It is enabled by default. You need to pass addition flag--skip-importsto disable it.gnodev test --precompileprecompile imports automatically.It also fixes the flag
--outputflag ingnodev precompile. Currently, it assumes that the output dir contains the pkg path. Which results in an error.Fix error
cannot find package...while runninggnodev testby creating temporary go.mod file in the temporary root directory.Try to find the nearest go.mod file, run
go buildin the same folder.Currently,
stdlibs/stdshimcontains generated*.gen.gofiles. While other packages in the stdlibs contains*.gnofiles. Replaced generated files with*.gnofiles.How has this been tested?
The above command precompiles
acland its imports.Addresses #415