Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PoC: VMKeeper.QueryEvalJSON #444

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

anarcher
Copy link
Contributor

@anarcher anarcher commented Dec 29, 2022

Description

Render is an interesting feature in gno. But IMHO, Query with json would be nice to programmatically interact.

package hello

type User struct {
        ID   int    `json:"id"`
        Name string `json:"name"`
}

func Hello() *User {
        return &User{ID: 1, Name: "hello"}
}
$ gnokey query "vm/qeval" --data "gno.land/r/test2/hello2
Hello()"
height: 0
data: {"id":1,"name":"hello"}

I'm not sure that this approach is suitable or not in gno. and it`s not yet an accurate, performant json encoder for now. it's just POC.
What do you think about this approach? :-)

How has this been tested?

Partially.

@moul
Copy link
Member

moul commented Jan 19, 2023

Related with #464

@moul moul mentioned this pull request Jan 19, 2023
@moul
Copy link
Member

moul commented Jan 24, 2023

FYI, I'm exploring a different way to manage this here: #439

@anarcher
Copy link
Contributor Author

FYI, I'm exploring a different way to manage this here: #439

Ok, I'm fine to close this PR. :->

@moul
Copy link
Member

moul commented Jan 25, 2023

There is no choice made yet. Let's keep this PR open while the discussion is still ongoing.

@jaekwon jaekwon requested a review from a team as a code owner April 20, 2023 22:14
@moul moul added this to the 💡Someday/Maybe milestone Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔵 Not Needed for Launch
Status: No status
Status: In Review
Development

Successfully merging this pull request may close these issues.

2 participants