Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: don't fetch module if replaced with dir #533

Merged
merged 3 commits into from
Feb 27, 2023
Merged

feat: don't fetch module if replaced with dir #533

merged 3 commits into from
Feb 27, 2023

Conversation

harry-hov
Copy link
Contributor

Description

Skip fetching replaced modules if replaced with dir

How has this been tested?

tests and manually

Related #462

@harry-hov harry-hov marked this pull request as ready for review February 21, 2023 20:17
@harry-hov harry-hov requested a review from a team as a code owner February 21, 2023 20:17
@harry-hov harry-hov self-assigned this Feb 22, 2023
zivkovicmilos
zivkovicmilos approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 💯

I've left a few minor comments, nothing major to address

pkgs/gnolang/gnomod/file.go Show resolved Hide resolved
pkgs/gnolang/gnomod/gnomod.go Show resolved Hide resolved
moul
moul approved these changes Feb 27, 2023
View reviewed changes
Copy link
Member

@moul moul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@moul moul merged commit 3da8a9a into gnolang:master Feb 27, 2023
@harry-hov harry-hov mentioned this pull request Feb 27, 2023
Open
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zivkovicmilos zivkovicmilos zivkovicmilos approved these changes

@moul moul moul approved these changes

Assignees

@harry-hov harry-hov

Labels
None yet
Projects
🚀 The Launch
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@harry-hov @moul @zivkovicmilos