-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(website): add dark theme switcher, and dark theme for hljs #548
feat(website): add dark theme switcher, and dark theme for hljs #548
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 💯
Thank you also for the attributions in-code, it's rare to see these days
let's do it more. we can't do long-term projects like this without being transparent and fair. any suggestion on how to improve this with CI/CD, contributions.md? |
@zivkovicmilos review addressed :) @moul I think the process can only be part automated. But here's my 2c on how maybe it could be done: If we want to list all the contributions, we could use All contributors as a starting point for categories to list. I don't necessarily agree with the whole thing (especially the putting-200-images-in-README part). I think it is important that contributions are recognized, while at the same time not making it extra-prominent in the README (to avoid pull requests which fix a typo in a comment or readme file just so that their name can show up on the repository home). Some of those can be automated (ie. git commit log, github API for PRs/issues), but some of them should probably still come in manually (ie. design). Then we should list code contributed from external projects. This should be:
If we are listing both contributors and deps/snippets credits, then maybe a |
About our contributors, I'm not afraid, we've git to keep track, and we're building Evaluation DAO #407 to manage contributions and contributors at scale. I was wondering specifically about copyrighted snippets, libs, and inspirations. I think we can move to #498 if we want to continue the discussion. |
Completing work started in #515.
Screencast.from.2023-02-28.19-04-21.webm