chore: add stringer to dependency tools #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following this [documented pattern][0], `make stringer` can now be invoked by a developer without the need to have the `stringer` binary in his/her path. In addition this ensures everyone use the same version of the tool (the version is tracked in go.mod). [0]: https://github.com/golang/go/wiki/Modules#how-can-i-track-tool-dependencies-for-a-module
|
Thank you Thomas, What do you think about maintaining the current approach, but using a separate go.mod file to keep the main one as concise as possible while still retaining the same benefits? -> https://github.com/gnolang/gno/tree/master/misc/devdeps If you also prefer this method, let's update our CONTRIBUTING.md file too. Else, let's consider removing |
|
Oh I missed there was already a dependency management pattern in the repo. Indeed the benefit of the existing one is it doesn't add dependencies to the main |
thehowl
approved these changes
Mar 27, 2023
r3v4s
pushed a commit
to r3v4s/gno
that referenced
this pull request
Mar 28, 2023
* chore: add stringer to dependency tools Following this [documented pattern][0], `make stringer` can now be invoked by a developer without the need to have the `stringer` binary in his/her path. In addition this ensures everyone use the same version of the tool (the version is tracked in go.mod). [0]: https://github.com/golang/go/wiki/Modules#how-can-i-track-tool-dependencies-for-a-module * fix: use existing dep management for stringer * go mod tidy again
peter7891
pushed a commit
that referenced
this pull request
Mar 29, 2023
* chore: add stringer to dependency tools Following this [documented pattern][0], `make stringer` can now be invoked by a developer without the need to have the `stringer` binary in his/her path. In addition this ensures everyone use the same version of the tool (the version is tracked in go.mod). [0]: https://github.com/golang/go/wiki/Modules#how-can-i-track-tool-dependencies-for-a-module * fix: use existing dep management for stringer * go mod tidy again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following this documented pattern,
make stringercan now beinvoked by a developer without the need to have the
stringerbinary inhis/her path.
In addition this ensures everyone use the same version of the tool (the
version is tracked in go.mod).