Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing consensus_params RPC call to HTTP clients #678

Merged
merged 1 commit into from
Mar 30, 2023
Merged

fix: add missing consensus_params RPC call to HTTP clients #678

merged 1 commit into from
Mar 30, 2023

Conversation

zivkovicmilos
Copy link
Member

Description

This PR adds a missing consensus_params RPC call to existing HTTP clients.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist (for contributors)

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Manually verified the client can return ConsensusParams for a given height.

@zivkovicmilos zivkovicmilos added the 🐞 bug Something isn't working label Mar 30, 2023
@zivkovicmilos zivkovicmilos requested a review from a team as a code owner March 30, 2023 13:22
@zivkovicmilos zivkovicmilos self-assigned this Mar 30, 2023
@thehowl thehowl merged commit 28c1984 into gnolang:master Mar 30, 2023
@zivkovicmilos zivkovicmilos deleted the fix/add-missing-params-call branch March 30, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thehowl thehowl thehowl approved these changes

Assignees

@zivkovicmilos zivkovicmilos

Labels
🐞 bug Something isn't working
Projects
🚀 The Launch
Status: No status
🧐 Review Meeting
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zivkovicmilos @thehowl