refactor(tm2/pkg/db): Avoid panicking when creating DBs. #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Panic is not designed for error handling. Panic is designed for handling exceptional situations, like out-of-bounds array indexing. Using panic for error handling, we are swallowing some errors and we might cause inconsistent behavior not cleaning resources properly. Signed-off-by: Antonio Navarro <antnavper@gmail.com>
Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
ajnavarro
force-pushed
the
refactor/avoid-using-panic-on-db
branch
from
bcf935b
to
fc2f28d
Compare
moul
approved these changes
Apr 11, 2023
peter7891
pushed a commit
that referenced
this pull request
May 9, 2023
Co-authored-by: Antonio Navarro <ajnavarro@pop-os.localdomain>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor all DB New methods to avoid panicking.
Panic is not designed for error handling. Panic is designed for handling exceptional situations, like out-of-bounds array indexing. Using panic for error handling, we are swallowing some errors and we might cause inconsistent behavior not cleaning resources properly.
I tried to do this refactor as small as possible, modifying one interface and its implementations at a time, moving panics up into the stack, until eventually all panics are removed.
How has this been tested?
All existing tests have been refactored to check for errors.
Related issue: #532