Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add explanations about how to use gofumpt in vim #747

Merged
merged 3 commits into from
May 4, 2023

Conversation

grepsuzette
Copy link
Contributor

@grepsuzette grepsuzette commented Apr 15, 2023

How has this been tested?

It's what I have been using for a weekmonth or two.
There may be more succint ways to do this.

BTW if someone knows how to have lint enabled in vim on .gno files, let me know.

@tbruyelle
Copy link
Contributor

Have you seen this https://github.com/gnolang/gno/blob/master/CONTRIBUTING.md#vim-support ?
This is what I use and it works well.

Copy link
Member

@thehowl thehowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me I just changed gofmt to gofumpt as I had it installed in my $PATH 😄 But this can be a good way to avoid installing it.

For what regards linting in Gno files, I haven't configured it yet. But it probably can be done in a "basic" manner with revive. It would be cool to have it with golangci-lint using the configuration of the repository and adding support for linting gno files.

CONTRIBUTING.md Outdated Show resolved Hide resolved
@tbruyelle
Copy link
Contributor

tbruyelle commented Apr 18, 2023

Have you seen this https://github.com/gnolang/gno/blob/master/CONTRIBUTING.md#vim-support ? This is what I use and it works well.

Oh sorry I didn't notice this was a PR so I hadn't look at the code before submitting my answer 😅

Indeed the comment about gofumpt involves that it is in the PATH 🙏

@thehowl
Copy link
Member

thehowl commented Apr 20, 2023

This looks good to me, but I'll ask @moul to merge, as I know CONTRIBUTING is one of the "protected" files in CODEOWNERS :)

@moul moul merged commit 836f006 into gnolang:master May 4, 2023
peter7891 pushed a commit that referenced this pull request May 9, 2023
Co-authored-by: grepsuzette <grepsuzette@users.noreply.github.com>
moul-bot pushed a commit that referenced this pull request May 19, 2023
Co-authored-by: grepsuzette <grepsuzette@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants