chore(gnolang): add challenges #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add 2 challenges for map and slice literals, as described in gnolang#758 - Add a challenge to handle chained panics, as described in gnolang#756 - Add a challenge to handle a specific rule of recover, as described in this [comment][0] Also add some working recover cases in `tests/files`, to increase code coverage. If you manage to solve one of these challenges by updating the gnovm code, move those files into the `gnovm/test/files` folder (eventually increment the number suffix in the name according to existing files). [0]: gnolang#756 (comment)
moul
approved these changes
Apr 20, 2023
thehowl
reviewed
Apr 20, 2023
|
|
||
| // Error: | ||
| // first | ||
| // second |
There was a problem hiding this comment.
Suggested change
| // second | |
| // second |
There was a problem hiding this comment.
Got ninja'd by manfred... shouldn't be too much of a problem though, if somebody does fix the challenges they'll probably have to adjust the output anyway.
yes :)
| // Output: | ||
| // g recover undefined | ||
| // f recover wtf | ||
| // false |
|
Got ninja'd by manfred... shouldn't be too much of a problem though, if somebody does fix the challenges they'll probably have to adjust the output anyway. |
This also surprised me, initially I was expecting |
peter7891
pushed a commit
that referenced
this pull request
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you manage to solve one of these challenges by updating the gnovm code, move those files into the
gnovm/test/filesfolder (eventually increment the number suffix in the name according to existing files).