chore: improve output on vm tests #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is an awesome idea :) |
|
IMHO the diff on tests are not intended to be used as a patch, but to easily see what is the difference between the obtained and expected result. The main problem I had when I was checking the fails on master was that the output was so verbose that was difficult to see what was failing. So I think leaving the output only as the diff is a better way of improving the time needed to fix any problems that these tests might catch in the future. |
ajnavarro
force-pushed
the
fix/improve-vm-file-tests
branch
from
33075e3
to
497181b
Compare
tbruyelle
approved these changes
Apr 26, 2023
|
You have to run |
|
cc @jeronimoalbi - would this break anything in the parser? |
Instead of printing the expected and actual output, create a diff to see what specifically changed. Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
ajnavarro
force-pushed
the
fix/improve-vm-file-tests
branch
from
497181b
to
ee107c7
Compare
|
Hi @ajnavarro, could you please add before/after examples in the PR body for better comprehension of the changes? Also, there is an alternative workflow that requires running two commands, namely WARN: new dependency. |
|
@moul Output examples Before: After: |
I think the flag you mention is called
It was an indirect dependency, because this is what |
Right |
zivkovicmilos
approved these changes
May 15, 2023
There was a problem hiding this comment.
This has got to be the longest PR description we've had to date 🙂
The diff view is much cleaner 💯
@moul are we fine with adding this external dependency?
|
@zivkovicmilos the dependency was already there. I'm using the same library that Testify uses under the hood for diff assertions. |
thehowl
approved these changes
May 17, 2023
There was a problem hiding this comment.
I like this 👍
Maybe a compromise with what @tbruyelle was also saying is to make it so that, when writing out the diff, all the context lines are printed (not just the different ones)? If difflib doesn't support this directly ie by setting context to -1, we could make Context something like 1 << 31...
This dependency only affects the advanced developer tools and not runtime. It offers flexibility and goes in the right direction. We can create multiple go.mod files to keep core libraries minimal. Reverting is also easy if needed. Let's go for it! 👍 Edit: maybe we'll want to add a toggle to get the previous behavior. |
moul
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of printing the expected and actual output, create a diff to see what specifically changed.
Before:
After: