Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix CI not testing the examples/ folder #784

Merged
merged 2 commits into from
Apr 27, 2023
Merged

chore: fix CI not testing the examples/ folder #784

merged 2 commits into from
Apr 27, 2023

Conversation

moul
Copy link
Member

@moul moul commented Apr 26, 2023 •
edited
Loading

  • Re-enable the gno test ./examples on the CI.
  • Fix a broken test.
  • Allow init() to call GetOrigCaller in testing context.

Fix #782

@moul
chore: fix CI not testing the examples/ folder
43dddb7 
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
@moul moul self-assigned this Apr 26, 2023
@moul moul mentioned this pull request Apr 26, 2023
Closed
@moul
chore: fix broken tests, thx to @jaekwon's comments
e59e25b 
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
@moul moul marked this pull request as ready for review April 26, 2023 12:24
@moul moul requested a review from a team as a code owner April 26, 2023 12:24
@moul moul added the 🐞 bug Something isn't working label Apr 26, 2023
zivkovicmilos
zivkovicmilos approved these changes Apr 26, 2023
View reviewed changes
Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests run fine now in the CI ✅

.github/workflows/examples.yml Show resolved Hide resolved
@moul moul mentioned this pull request Apr 27, 2023
Merged
@moul moul merged commit e8d9762 into gnolang:master Apr 27, 2023
@moul moul deleted the dev/moul/examples-test-ci branch April 27, 2023 19:19
peter7891 pushed a commit that referenced this pull request May 9, 2023
@moul @peter7891
chore: fix CI not testing the examples/ folder (#784)
a1de3bf
moul-bot pushed a commit that referenced this pull request May 19, 2023
@moul
chore: fix CI not testing the examples/ folder (#784)
06a30d1
@moul moul added this to the 🌟 main.gno.land (wanted) milestone Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zivkovicmilos zivkovicmilos zivkovicmilos approved these changes

@tbruyelle tbruyelle tbruyelle approved these changes

@ajnavarro ajnavarro ajnavarro approved these changes

Assignees

@moul moul

Labels
🐞 bug Something isn't working
Projects
😎 Manfred's Board
Status: ✅ Done
🚀 The Launch
Archived in project
🧐 Review Meeting
Archived in project
Milestone
🌟 main.gno.land (wanted)
Development

Successfully merging this pull request may close these issues.

cd examples; make test fails
4 participants
@moul @tbruyelle @ajnavarro @zivkovicmilos