-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cmd/gno): add support for gno.mod projects in gno doc #829
Conversation
It would seem like tests are failing because they can't reach test3? Should we change gno mod tests to not use the network? Shall I open an issue for that? |
Please. I was thinking about that for a long time. Maybe it's a good idea if we can start local test server for testing. |
It looks like it was a bug actually, but still I think tests should not rely on the network. I'll make an issue; I've added tests so this is now ready for review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments. Overall solid work 💯
Co-authored-by: Hariom Verma <hariom18599@gmail.com>
* feat(cmd/gno): add support for gno.mod projects in gno doc * fix tests * remove bfsRootDir * update compat doc * add tests * harioms pr merged, remove duplicate code * fix: tests for wrong arguments passed to newDirs * xx * fix dirsempty * Apply suggestions from code review Co-authored-by: Hariom Verma <hariom18599@gmail.com> * s/tryParse/parse/g --------- Co-authored-by: Hariom Verma <hariom18599@gmail.com>
Part of #522.
Feature is ready for review; will add some tests to check the functionality in all edge cases probably tomorrow.
Description
The
gno doc
command now understands local directories which usegno.mod
.One of the caveats is that the command will likely always complains that it wants a
--root-dir
variable; but I think we'll need to find a system-wide solution for this eventually (ie. when gno comes out of the first phase of development, and users install it in/usr/lib/gno
, this should default to that directory).(Sorry for the small font, I still had my terminal in full-screen...)
Contributors Checklist
BREAKING CHANGE: xxx
message was included in the description