Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve tests and docs of persisted types #833

Merged
merged 11 commits into from
May 26, 2023
Merged

chore: improve tests and docs of persisted types #833

merged 11 commits into from
May 26, 2023

Conversation

moul
Copy link
Member

@moul moul commented May 19, 2023 •
edited

Related with #817

moul added 2 commits May 19, 2023 11:42
@moul
chore: improve tests and debugging of persisted types
d41d4e7 
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
@moul
chore: improve tests and debugging of persisted types
37c32d3 
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
@moul moul self-assigned this May 19, 2023
@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label May 19, 2023
@moul moul changed the title dev/moul/persisted types WIP: chore: improve tests and debugging of persisted types May 19, 2023
moul added 2 commits May 19, 2023 14:21
@moul
chore: fixup
ea67b9f 
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
@moul
chore: fixup
8d7c1a5 
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
jaekwon
jaekwon approved these changes May 22, 2023
View reviewed changes
Copy link
Contributor

@jaekwon jaekwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

preapproving after comments but lmk if there are significant changes pls.

moul added 2 commits May 25, 2023 08:24
@moul
chore: apply suggestions
ccf6d13
@moul
chore: update test with more cases
6bd84c0 
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
@moul moul changed the title WIP: chore: improve tests and debugging of persisted types chore: improve tests and debugging of persisted types May 25, 2023
moul added 2 commits May 25, 2023 08:58
@moul
chore: add persist_map.gno challenge
f140213 
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
@moul
chore: fixup
1d796bf 
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
@moul moul marked this pull request as ready for review May 25, 2023 07:16
@moul moul requested a review from a team as a code owner May 25, 2023 07:16
@moul moul changed the title chore: improve tests and debugging of persisted types chore: improve tests and docs of persisted types May 25, 2023
thehowl
thehowl reviewed May 25, 2023
View reviewed changes
gnovm/docs/go-gno-compatibility.md Outdated Show resolved Hide resolved
gnovm/docs/go-gno-compatibility.md Outdated Show resolved Hide resolved
@moul @thehowl
Update gnovm/docs/go-gno-compatibility.md
4be6665 
Co-authored-by: Morgan <git@howl.moe>
@moul moul merged commit b1dbad5 into gnolang:master May 26, 2023
44 checks passed
@moul moul deleted the dev/moul/persisted-types branch May 26, 2023 15:07
@moul moul added this to the 🌟 main.gno.land (wanted) milestone Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbruyelle tbruyelle tbruyelle approved these changes

@thehowl thehowl thehowl approved these changes

@jaekwon jaekwon jaekwon approved these changes

Assignees

@moul moul

Labels
📦 🤖 gnovm Issues or PRs gnovm related
Projects
😎 Manfred's Board
Status: Done
🚀 The Launch
Archived in project
🧐 Review Meeting
Archived in project
Milestone
🌟 main.gno.land (wanted)
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@moul @jaekwon @tbruyelle @thehowl