Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: create docs/go-gno-compatibility.md #745

Merged
merged 5 commits into from
May 15, 2023
Merged

chore: create docs/go-gno-compatibility.md #745

merged 5 commits into from
May 15, 2023

Conversation

moul
Copy link
Member

@moul moul commented Apr 14, 2023 •
edited
Loading

Add a docs/go-gno-compatibility doc skeleton.

TODO:

  • fill it with current state
  • keep it updated in PRs (update CONTRIBUTING.md?)

Related with gnolang/hackerspace#5

@moul moul requested a review from a team as a code owner April 14, 2023 10:37
@moul moul self-assigned this Apr 14, 2023
@jaekwon
Copy link
Contributor

jaekwon commented Apr 16, 2023

I think we should mark these as WIP: to distinguish from completed PRs.

@moul moul marked this pull request as draft April 16, 2023 19:04
@moul moul changed the title chore: create docs/go-gno-compatibility.md WIP chore: create docs/go-gno-compatibility.md Apr 16, 2023
@moul
Copy link
Member Author

moul commented Apr 16, 2023

@jaekwon done.

@harry-hov could you cherry-pick my PR and create yours or open a PR against mine?

@moul
chore: move file to gnovm
2ca6f60 
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
@moul
chore: add symlink
9f1806a 
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
@moul
chore: fixup
11e1936 
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
@moul
chore: fixup
fe43d51 
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
@moul moul changed the title WIP chore: create docs/go-gno-compatibility.md chore: create docs/go-gno-compatibility.md Apr 24, 2023
@moul moul marked this pull request as ready for review April 24, 2023 23:50
@moul
Copy link
Member Author

moul commented Apr 25, 2023

Improved format. Can you rebase my PR on top of yours?

Consider merging now and updating tables in later PRs. Thoughts?

@ajnavarro
Copy link
Contributor

Nice idea.

Could we point to a specific Go version? like, Gno supports Go v1.4 without goroutines, or something like that. That will help Go developers a lot to understand what they should expect about supported tokens.

@moul
Copy link
Member Author

moul commented Apr 28, 2023

Nice idea.

Could we point to a specific Go version? like, Gno supports Go v1.4 without goroutines, or something like that. That will help Go developers a lot to understand what they should expect about supported tokens.

I agree that a succinct introduction for incoming gophers is a good idea. The task at hand is to craft a brief statement that is both truthful and attention-grabbing.

@zivkovicmilos
Copy link
Member

@moul @harry-hov
What is the current state of this PR?

@thehowl thehowl merged commit 87b96d2 into master May 15, 2023
@thehowl thehowl deleted the moul-patch-1 branch May 15, 2023 15:31
@moul moul mentioned this pull request May 19, 2023
Merged
3 tasks
moul-bot pushed a commit that referenced this pull request May 19, 2023
@moul
chore: create docs/go-gno-compatibility.md (#745)
b2d738e 
* chore: create docs/go-gno-compatibility.md

* chore: move file to gnovm

Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>

* chore: add symlink

Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>

* chore: fixup

Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>

* chore: fixup

Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>

---------

Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
@moul moul added this to the 🌟 main.gno.land (wanted) milestone Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thehowl thehowl thehowl approved these changes

Assignees

@moul moul

@harry-hov harry-hov

Labels
None yet
Projects
😎 Manfred's Board
Status: ✅ Done
🚀 The Launch
Archived in project
🧐 Review Meeting
Archived in project
Milestone
🌟 main.gno.land (wanted)
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@moul @jaekwon @ajnavarro @zivkovicmilos @thehowl @harry-hov