Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Connection modal is still displayed when change a connection type #1240

Closed
elena-zh opened this issue Aug 12, 2021 · 2 comments
Closed

Connection modal is still displayed when change a connection type #1240

elena-zh opened this issue Aug 12, 2021 · 2 comments
Labels
app:CowSwap CowSwap app Bug Something isn't working Medium Severity indicator. It causes some undesirable behavior, but the system is still functional

Comments

@elena-zh
Copy link

Related to #1227 and #1234

  1. Connect a wallet
  2. Open side bar
  3. Press on the 'Change' button
  4. Connect another wallet

AR: Connection modal is still displayed
https://drive.google.com/file/d/1mZNLbEdppMQnpVSi-DNpsUg9c73tAt5r/view

ER: Close the connection modal.
In the previous version 'Account' modal appeared right after connection of another wallet. Do we need to open side bar now or we just simply could show something like 'Connected! modal?
@elena-zh elena-zh added app:CowSwap CowSwap app Medium Severity indicator. It causes some undesirable behavior, but the system is still functional Bug Something isn't working labels Aug 12, 2021
@elena-zh elena-zh mentioned this issue Aug 12, 2021
Merged
@fairlighteth
Copy link
Contributor

Should be fixed in #1310 @elena-zh

@elena-zh
Copy link
Author

Yes, thanks @biocom .
I have verified this issue today in #1279 : works fine there

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
app:CowSwap CowSwap app Bug Something isn't working Medium Severity indicator. It causes some undesirable behavior, but the system is still functional
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fairlighteth @elena-zh