Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Placing order after approving token has no feedback #765

Open
alfetopito opened this issue Jun 11, 2021 · 1 comment
Open

Placing order after approving token has no feedback #765

alfetopito opened this issue Jun 11, 2021 · 1 comment
Labels
app:CowSwap CowSwap app Bug Something isn't working wontfix Stale issue

Comments

@alfetopito
Copy link
Contributor

Description
Placing order after approving token has no feedback.

Order is placed but no pop up nor post confirmation modal was displayed.

It was observed on this version https://pr753--gpswapui.review.gnosisdev.com/

How to Reproduce

  1. Pick a sell token that you have not yet approved
  2. Fill in the relevant fields
  3. Send the approval tx
  4. Once that's mined, place the swap order
  • Post swap modal was not displayed
  • Cow sound did not play
  • Toast notification was not displayed

Expected behavior
After a swap order is sent:

  • Post swap modal should be displayed
  • Toast notification should be displayed
  • Cow sound should be played

Screenshots
N/A

Additional context
Reported by @avsavsavs during Kaffeasdasd testing https://pr753--gpswapui.review.gnosisdev.com/

@alfetopito alfetopito added Bug Something isn't working app:CowSwap CowSwap app labels Jun 11, 2021
@stale
Copy link

stale bot commented Mar 30, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you think it shouldn't be closed, speak now or forever hold your peace.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
app:CowSwap CowSwap app Bug Something isn't working wontfix Stale issue
Projects
None yet
Development

No branches or pull requests

1 participant