Skip to content
This repository has been archived by the owner on Apr 4, 2022. It is now read-only.

[presign] Explorer: Status for pre-signing #628

Closed
alfetopito opened this issue Aug 31, 2021 · 3 comments · Fixed by #826
Closed

[presign] Explorer: Status for pre-signing #628

alfetopito opened this issue Aug 31, 2021 · 3 comments · Fixed by #826
Assignees
Labels
app:Explorer Explorer App Critical Severity indicator for defects. ndicates complete shut-down of the process. Nothing can proceed furt Protofire task to the protofire team

Comments

@alfetopito
Copy link
Contributor

Summary

  1. Add new order status: signature pending
  2. Potentially refactor how status are loaded to use API responses instead of calculating them locally

Context:

@anxolin @W3stside @alfetopito

Just pinging you guys so you are aware of the new order status (for an order that was accepted by the orderbook and is waiting for the on-chain presignature).

Originally posted by @nlordell in gnosis/gp-v2-services#1025 (comment)

@nlordell
Copy link
Contributor

Just as an update, the new status was renamed to presignaturePending.

@alfetopito alfetopito changed the title @anxolin @W3stside @alfetopito Add status: signature pending Aug 31, 2021
@anxolin anxolin changed the title Add status: signature pending [presign] Explorer: Status for pre-signing Oct 13, 2021
@alfetopito alfetopito mentioned this issue Oct 19, 2021
4 tasks
@anxolin
Copy link
Contributor

anxolin commented Oct 28, 2021

Not sure if we would like to do this, but maybe is nice to see in the explorer the signing method too: ie. ethsign, eip712, pre-sign, ...

Being a explorer for the protocol, make sense to expose all the protocol info relative to the order. Not sure if there should be some hidden fields and this belong there. Adding now pre-sign orders, maybe is interesting to add this too

@alfetopito
Copy link
Contributor Author

I agree, but I think this is a different task.

I would also want to have what you mentioned today: show & decode appData, loading ipfs data if any

@henrypalacios henrypalacios self-assigned this Nov 5, 2021
@henrypalacios henrypalacios added the Protofire task to the protofire team label Nov 5, 2021
@fapesteguia fapesteguia added the Critical Severity indicator for defects. ndicates complete shut-down of the process. Nothing can proceed furt label Nov 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
app:Explorer Explorer App Critical Severity indicator for defects. ndicates complete shut-down of the process. Nothing can proceed furt Protofire task to the protofire team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants