-
Notifications
You must be signed in to change notification settings - Fork 15
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1025 +/- ##
==========================================
- Coverage 64.47% 64.35% -0.13%
==========================================
Files 123 123
Lines 23350 23471 +121
==========================================
+ Hits 15056 15105 +49
- Misses 8294 8366 +72 |
Could we rebase this set of branches on main so that it includes the change to SQL query to make reviewing easier? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The SQL query looks good to me.
Maybe an extra test could be that an expired order that is pending a presignature returns "expired" (and not "pending").
ae92a61
to
dcccde8
Compare
bd237d8
to
cea557c
Compare
@vkgnosis should be rebased now. |
@@ -447,7 +447,7 @@ components: | |||
OrderStatus: | |||
description: The current order status | |||
type: string | |||
enum: [open, fulfilled, cancelled, expired] | |||
enum: [signaturePending, open, fulfilled, cancelled, expired] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anxolin @W3stside @alfetopito
Just pinging you guys so you are aware of the new order status (for an order that was accepted by the orderbook and is waiting for the on-chain presignature).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for letting us know.
I've created one task for the explorer gnosis/gp-ui#628
I believe Anxo is taking care of cowswap changes.
dcccde8
to
b375b09
Compare
fce17e2
to
df63bd1
Compare
This PR adds a
SignaturePending
status to order for pre-sign orders in theOrderMetadata
for signalling that a pre-sign order is waiting for a pre-signature in the GPv2 settlement contract.Please note that my SQL skillz are 👎. So please scrutinize the query modification that was made.
Test Plan
Added new unit tests for the added order status computation. Added an ignored test for the Postgres query for presignature status that can be manually run:
Query Rational
We use a subquery in order to get the latest presignature.
This seems to be more performant than a
JOIN LEFT LATERAL
.