Adding signature pending orderStatus

[henrypalacios]

Summary

Closes #628

• Adding signing in order status
  
• Maintain consistency with status 'Cancelled' instead of 'Canceled' from cowswap
  

To test

Signing status.

• Go to https://cowswap.dev.gnosisdev.com/#/swap
• Connect with gnosis-safe through wallet connect
• Once connected with gnosis-safe, create a swap.
• Paste wallet address in https://pr826--gpui.review.gnosisdev.com/
• View new order with signing status in table.

View the OrderStatus signing label

• Go to Storybook/Orders/StatusLabel/Signing

[github-actions]

• 🔭 Explorer: Explorer test app
• 🔒 Safe Swap App: Trade test app (add to your safe apps)
• 📈 Trade: Trade test app
• 📚 Storybook: Component stories

[elena-zh]

Hey @henrypalacios , just have tried to test your PR.
I was not able to get 'Signing' (or so?) status in the explorer for an order.
I connected the app with Gnosis Safe, then signed an order: the order was always in 'Open' status when it was in 'Signing' phase

[elena-zh]

Hey @henrypalacios , could you please take a look into #612 task in this PR?
It is also related to sync statuses case.

[alfetopito]

Looking and working great, some minor comments regarding the code

[henrypalacios]

@elena-zh from #612 I have only been able to change 'Canceled' to 'Cancelled' to maintain consistency with cowswap as you suggest, I have not found a way to be able to synchronize the cancelling status.

As @alfetopito mentioned we don't get this kind of status from the back-end, it occurs to me to show it in cancelling until we don't have a confirmation of mining on the blockchain.

But in any case, we will handle this in another issue.

[elena-zh]

HI @henrypalacios , thank you for taking a look into the #612 issue and your explanation.
I have verified the recent changes: now I'm able to see an order in 'Signature pending' status.
However, could we make statuses the same in CowSwap and in the Explorer: use 'Signing' instead of 'Signature pending'?

It will make the status shorter and it will be better displayed in a UI (in 1 line in the Orders list and in a mobile versions with small screen width)

Also, we update statuses each 30 sec, and it might happen that the order is already filled, but it is still in 'Signature pending' status in Explorer.

Maybe we could decrease this interval?
@alfetopito , WDYT?

[henrypalacios]

@elena-zh I agree with you, I have changed it to signing.

In your experience in Mainnet, what do you think would be the most convenient refresh time?,
I have tried to lower it to 25sec.

But maybe @alfetopito can suggest something.

[elena-zh]

In your experience in Mainnet, what do you think would be the most convenient refresh time?

Can't guess... That is why I addresses this question to @alfetopito

The only thing I can add that we can place orders in XDAI besides Mainnet. Transactions run quickly there.

[elena-zh]

@henrypalacios , 'signing' status looks much better!
Just while we are waiting for Leandro's answer, I'd like to mention a new nitpick: shimming effect for the 'signing' status is displayed only for the 'key' icon, not for the whole status.
Could we show shimming effect to the whole status?

[henrypalacios]

@elena-zh Done!

[alfetopito]

I don't think it's a big deal to wait a little longer to see the status changing, 30s is fine.

[alfetopito]

2 minor comments

[elena-zh]

Great!

[alfetopito]

Approved!

Only one minor change below :)

[anxolin]

Nice!! I would close version with this and whatever is ready 👌