Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh 1301 network refactoring #1345

Merged
merged 5 commits into from
Jul 21, 2021
Merged

Conversation

sche
Copy link
Contributor

@sche sche commented Jul 21, 2021

No description provided.

@codecov
Copy link

codecov bot commented Jul 21, 2021

Codecov Report

Merging #1345 (efb4368) into main (0017fff) will increase coverage by 4.85%.
The diff coverage is 40.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1345      +/-   ##
==========================================
+ Coverage   15.45%   20.31%   +4.85%     
==========================================
  Files         252      339      +87     
  Lines        6115    14287    +8172     
==========================================
+ Hits          945     2902    +1957     
- Misses       5170    11385    +6215     
Impacted Files Coverage Δ
Multisig/App/AppDelegate+Messaging.swift 0.00% <0.00%> (ø)
...g/Cross-layer/Configuration/ConfigurationKey.swift 41.37% <0.00%> (+4.34%) ⬆️
...hlytics Non-fatal Errors/MethodDecodingError.swift 0.00% <0.00%> (ø)
...ytics Non-fatal Errors/TransferDecodingError.swift 0.00% <0.00%> (ø)
...tisig/Cross-layer/UserDefaultPropertyWrapper.swift 36.36% <ø> (ø)
Multisig/Data/Persistence/CoreDataStack.swift 63.63% <ø> (+18.18%) ⬆️
.../Safe Client Gateway Service/BalancesRequest.swift 0.00% <0.00%> (ø)
...e Client Gateway Service/CollectiblesRequest.swift 0.00% <0.00%> (ø)
...nt Gateway Service/ConfirmTransactionRequest.swift 0.00% <0.00%> (ø)
...Safe Client Gateway Service/FiatCodesRequest.swift 0.00% <0.00%> (ø)
... and 540 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4342822...efb4368. Read the comment docs.

Copy link
Contributor

@DmitryBespalov DmitryBespalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EPIC! ✨

@DmitryBespalov DmitryBespalov merged commit 2036945 into main Jul 21, 2021
@DmitryBespalov DmitryBespalov deleted the gh-1301-network-refactoring branch July 21, 2021 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants