Gh 1371 fix tracking #1375
Merged
Gh 1371 fix tracking #1375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
biafra23
reviewed
Aug 9, 2021
|
|
||
| let message = """ | ||
| Gnosis Safe \(version) | ||
| Safe address: \(safe?.address ?? "None") | ||
| Safe address: \(address) | ||
| Chain: \(chain) |
There was a problem hiding this comment.
We (the Android team) decided to also include the id in braces as in: Rinkeby (4)
There was a problem hiding this comment.
Here I asked a related question safe-global/safe-android#1627 (comment)
Codecov Report
@@ Coverage Diff @@
## release/3.0.0 #1375 +/- ##
=================================================
- Coverage 20.19% 20.18% -0.01%
=================================================
Files 344 344
Lines 14382 14382
=================================================
- Hits 2904 2903 -1
- Misses 11478 11479 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles #1371, #1372, #1373, #1374