Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch RPC provider from the SDK #235

Closed
2 of 3 tasks
dasanra opened this issue Dec 9, 2021 · 2 comments · Fixed by #262
Closed
2 of 3 tasks

Fetch RPC provider from the SDK #235

dasanra opened this issue Dec 9, 2021 · 2 comments · Fixed by #262
Assignees
@DaniSomoza
Labels
Enhancement ✨ Design or functionality improvement

Comments

@dasanra
Copy link
Contributor

dasanra commented Dec 9, 2021 •
edited by DaniSomoza
Loading

Overview

As followup of safe-global/safe-apps-sdk#254 we need to cleanup the manual configuration of RPC endpoints for each chain. We should get this information using the Apps SDK detecting the WebApp current network

Goals

  • Remove chain dependency from TX-Builder and Drain Safe app

Requirements

  • Create a PR in safe-react updating the communicator to return the complete chain configuration
  • Upgrade types in safe-apps-sdk in case is necessary
  • Remove RPC endpoints from Tx-Builder and Drain Safe apps and get them from the SDK
@dasanra dasanra added the Enhancement ✨ Design or functionality improvement label Dec 9, 2021
@DaniSomoza DaniSomoza self-assigned this Dec 9, 2021
@dasanra dasanra mentioned this issue Dec 9, 2021
Merged
@DaniSomoza
Copy link
Contributor

Added safe-global/safe-apps-sdk#264 PR

@DaniSomoza DaniSomoza mentioned this issue Dec 10, 2021
Closed
@DaniSomoza
Copy link
Contributor

Added PR in safe-react: 5afe/safe-react#3164

@dasanra dasanra mentioned this issue Dec 15, 2021
Closed
@DaniSomoza DaniSomoza mentioned this issue Jan 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DaniSomoza DaniSomoza

Labels
Enhancement ✨ Design or functionality improvement
Projects
None yet
Milestone
No milestone
2 participants
@dasanra @DaniSomoza