Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Camera keeps being activated for too long #316

Closed
lukasschor opened this issue Dec 4, 2019 · 2 comments · Fixed by #2165
Closed

Camera keeps being activated for too long #316

lukasschor opened this issue Dec 4, 2019 · 2 comments · Fixed by #2165
Assignees
Labels
Bug 🐛 Something isn't working Major Needs to be fixed for immediate next public release. Updated The bug is still reproducible

Comments

@lukasschor
Copy link
Member

When initiating a transfer by scanning a QR code but then closing the camera mode, the camera keeps getting activated for about 20 seconds. This is both indicated by the recording symbol in the browser and the light right next to the camera.

How to reproduce

  1. Open Send flow

Screenshot 2019-12-04 at 21 53 17

  1. Open QR scan view

Screenshot 2019-12-04 at 21 53 25

  1. Close QR scan view

Screenshot 2019-12-04 at 21 53 43

@lukasschor lukasschor added Bug 🐛 Something isn't working Minor Needs to be fixed within the next 1-3 public releases. labels Dec 4, 2019
@lukasschor lukasschor added this to the Safe for Teams v1.5.0 (Transaction Context) milestone Dec 4, 2019
@lukasschor lukasschor removed this from the Safe for Teams v1.5.0 (Transaction Context) milestone Jan 8, 2020
@katspaugh
Copy link
Member

This can be still reproduced occasionally. Especially after the first time loading the page and allowing the camera permissions.
The camera turns off immediately after the second time using it.

The react-qr-reader library we're using was last updated two years ago. In the code, they do seem to stop the camera stream properly though. Although they don't release the srcObject.

There's a recently updated fork of this lib – https://github.com/kybarg/react-qr-scanner – that added TypeScript types. Might be worth giving it a try.

@katspaugh katspaugh added the Updated The bug is still reproducible label Apr 7, 2021
@tschubotz
Copy link
Member

Marking this as major since I think a too long activated camera is kind of sketchy - not create for a security-focused product

@tschubotz tschubotz added Major Needs to be fixed for immediate next public release. and removed Minor Needs to be fixed within the next 1-3 public releases. labels Apr 13, 2021
@katspaugh katspaugh self-assigned this Apr 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug 🐛 Something isn't working Major Needs to be fixed for immediate next public release. Updated The bug is still reproducible
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants