Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

[Transaction Cancellation] Design #404

Closed
fernandomg opened this issue Dec 27, 2019 · 10 comments
Closed

[Transaction Cancellation] Design #404

fernandomg opened this issue Dec 27, 2019 · 10 comments
Assignees
Labels
Critical Only for bugs in released apps, needs to be fixed asap and hotfix needs to be shipped.

Comments

@fernandomg
Copy link
Contributor

Implement designs based on feedback from #403

@fernandomg fernandomg added the Critical Only for bugs in released apps, needs to be fixed asap and hotfix needs to be shipped. label Dec 27, 2019
@fernandomg fernandomg added this to the Safe for Teams v1.5.0 (Transaction Context) milestone Dec 27, 2019
@fernandomg
Copy link
Contributor Author

@lukasschor, this is an ongoing work.

As purposed in #403, the intention is to display the actions in a tabular form.

After some back and forth, we couldn't find a better approach to use the 'linked-list' that the current tx detail shows, so we decided to rethink the whole votes section.

Having a tabular distribution with a row per user, with its possible actions (accept or cancel), and the last column to display extra information (as the 'executor' status).

The [Execute] button should appear in a latter row, under each action column, whenever it's possible.

You can see some wireframes here: https://wireframepro.mockflow.com/view/gsmultisig#/page/D44803dacf80a77d81dbf044743fe7ea7

@lukasschor
Copy link
Member

Did you also explore options going into this direction?

Screenshot 2020-01-07 at 11 13 45

Screenshot 2020-01-07 at 11 19 14

@alongoni
Copy link
Contributor

alongoni commented Jan 7, 2020

Thanks @lukasschor. The second option looks great. We can test the different states of the app.

@lukasschor lukasschor modified the milestones: Safe for Teams v1.5.0 (Transaction Context), Sprint 1 "Fitz Roy" Jan 8, 2020
@alongoni
Copy link
Contributor

alongoni commented Jan 8, 2020

@lukasschor do you prefer to keep the Confirm and Reject button down below?
multisig-buton-confirm-bottom

Or can we continue with the current location near each user / wallet? Perhaps this option is clearer.
multisig-buton-confirm

@lukasschor
Copy link
Member

Yes confirm can be up there and keep the cancel button below.

@alongoni
Copy link
Contributor

alongoni commented Jan 9, 2020

Hi @lukasschor!
Here can you see two flows:

  1. Reject (with 1 confirmation petition)
    Tx Details (reject flow)

  2. Confirmation (whit 1 reject tx petition)
    Tx Details (accept flow)

@fernandomg

@lukasschor
Copy link
Member

  1. Seeing this I would actually take back my vote for having reject at the bottom and have it also up there. Similar to how the confirm button is displayed
  2. I would not call the button "Confirm Reject", this seems very confusing to me
  3. There is a use-case to collect all confrmations and then execute later. However, for rejections I don't see this and would just force-execute with the last confirmation collected. What do you think?
  4. I would just call the buttons "Confirm" & "Reject" instead of "Confirm tx" & "Reject tx"

@fernandomg
Copy link
Contributor Author

  1. There is a use-case to collect all confrmations and then execute later. However, for rejections I don't see this and would just force-execute with the last confirmation collected. What do you think?

@lukasschor, So we should slightly modify the Approve Transaction modal for that particular case, isn't it?

image.png

  • No checkbox for execution
  • and leave only the first sentence of the red message: Approving this transaction executes it right away.

@alongoni
Copy link
Contributor

@lukasschor. We agrupated the two buttons (Confirm and Reject) near the user wallet.
Tx Details (reject flow)
Tx Details (accept flow) - case 1

This is other case, when a user confirm first and then have two options: Execute or Reject
Tx Details (accept flow) – case 2
@fernandomg

@lukasschor
Copy link
Member

Looks great!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Critical Only for bugs in released apps, needs to be fixed asap and hotfix needs to be shipped.
Projects
None yet
Development

No branches or pull requests

4 participants