Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate old create endpoints #161

Closed
Uxio0 opened this issue Nov 4, 2019 · 4 comments
Closed

Deprecate old create endpoints #161

Uxio0 opened this issue Nov 4, 2019 · 4 comments
Milestone

Comments

@Uxio0
Copy link
Member

Uxio0 commented Nov 4, 2019

At this point every client should be migrated to the new v2 CREATE2 endpoints, so old endpoints should be deprecated to prevent people creating old v0.1.0 Safes. The endpoints to be deprecated are:

  • POST /v1/safes/
  • POST /v1/safes/estimate/
  • PUT /v1/safes/{address}/funded/

What do you think @tschubotz @rmeissner @DmitryBespalov?

@rmeissner
Copy link
Member

do you have any stats on usage?

@Uxio0
Copy link
Member Author

Uxio0 commented Nov 4, 2019

@rmeissner That endpoint has created:

  • 1 Safe in November (Dima's testing one)
  • No Safes in October
  • 1 in September
  • 6 in August
  • 1 in July
  • 54 in June
  • 115 in May

I would say there's no risk on deprecating the endpoint in next version

@DmitryBespalov
Copy link

I would say I don't really know if the people who created safes with old endpoints have upgraded to the new app version. Maybe they still have the safe but did not actually use it and it sits on their phone.

I would be careful with our users on that side. I'd propose to send out a push notification and or write a blog post that we are deprecating old versions and people are encouraged to update to ta new version.

@rmeissner rmeissner added this to the Version 0.3.0: Road to Rome milestone Nov 12, 2019
@Uxio0
Copy link
Member Author

Uxio0 commented Nov 20, 2019

@DmitryBespalov This change would just affect people creating new safes, not for doing txs with old safes. I think it has been enough time to update the apps to the new versions. In my opinion we should just deprecate the endpoints and not make a big deal of that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants