Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return fiat values #38

Closed
tschubotz opened this issue Jul 9, 2019 · 2 comments
Closed

Return fiat values #38

tschubotz opened this issue Jul 9, 2019 · 2 comments
Assignees
@Uxio0
Milestone
Road to Rome

Comments

@tschubotz
Copy link
Member

See Epic for details: 5afe/safe#16
@tschubotz tschubotz changed the title Return fiat value Return fiat values Jul 9, 2019
@Uxio0 Uxio0 self-assigned this Jul 11, 2019
@rmeissner
Copy link
Member

Do we have any api proposals for this?

@Uxio0
Copy link
Member

Uxio0 commented Sep 17, 2019 •
edited
Loading

I would propose extending the json we return in the /balances/ endpoint:

[
  {
    "tokenAddress": null,
    "balance": "9159299696780"
  }
]
It could be
[
  {
    "tokenAddress": null,
    "balance": "9159999696780",
    "balanceUSD": "0.0018",
  }
]

@Uxio0 Uxio0 transferred this issue from 5afe/safe-relay-service Dec 10, 2019
@Uxio0 Uxio0 added this to the Road to Rome milestone Dec 10, 2019
@Uxio0 Uxio0 mentioned this issue Dec 11, 2019
Merged
@Uxio0 Uxio0 closed this as completed in 8d5c49f Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Uxio0 Uxio0

Labels
None yet
Projects
None yet
Milestone
Road to Rome
Development

No branches or pull requests
3 participants
@tschubotz @rmeissner @Uxio0