-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent Authenticator as 2FA option for new Safes #264
Comments
Phone without NFC1) Create SafeStill show this step but let the user know why 2FA is not possible. 2) Existing Safe - Enable 2FATell that enabling 2FA is not possible but you are still able to connect Authenticator when recovering. Alternatively, we could hide or grey out this option in the menu. 3) Existing Safe - Replace 2FATell that replacing 2FA is not possible but you are still able to connect Authenticator when recovering. 4) Recover SafeOnly allow connecting Authenticator. Don't show list of devices. 5) Existing Safe - Disable 2FAIn case some users use the Authenticator for dapps warn them that they won’t be able to setup Authenticator again in the Safe menu. They are still able to enable it during Safe recovery. https://www.dropbox.com/s/9rbd4omn7g8yjql/Without_NFC.jpg?dl=0 Phone with NFC1) Create SafeIn the list of devices we don't show Authenticator. Otherwise no changes. 2) Existing Safe - Enable 2FAIn the list of devices we don't show Authenticator. 3) Existing Safe - banner to switchShow it on Assets view and in the menu. You are able to close. 4) Existing Safe - Replace 2FAIn the list of devices we don't show Authenticator. 5) Recover SafeIn the list of devices we don't show Authenticator. 6) Existing Safe - Disable 2FA - no changeshttps://www.dropbox.com/s/hoy84o3mh27z0qn/With_NFC.jpg?dl=0 Banner for Authenticator: |
Do we want to make it this complex (implementation wise) ... I would have just adjusted the list where the user can select a 2fa factor. And in the worst case he could not select any device and therefore could not continue. This would require the least adjustments and would archive the same goal. |
Thanks for the update. I would not tell users that they are still able to connect to the Authenticator when recovering. That is confusing imo. Regarding Richard's comment, I'm all for minimizing implementation effort. Could you work with the mobile devs to see if we can come up with a version where e.g. just the 2FA list needs to be modified (if that's what would make this feature easier)?
What do you think? |
Regarding the message on the Authenticator: The message says "prevent unauthorized access". That won't happen and is a very dangerous thing to write imo. I would rather write something like this:
(If possible, I wouldn't write "Status Keycard". Otherwise we would have to update the text once we add something else.) What do you think? |
Also, what if the user doesn't have NFC? |
Here's some stats on the number of users of the extension to educate the discussion: users.pdf |
UX sync: leave out banners |
Changes: don't do banners, text changes, added "Get in touch button". Android without NFC: Android with NFC: iOS without NFC: https://www.dropbox.com/s/ant930hgkinnkoq/iOS_Without_NFC.png?dl=0 iOS with NFC: https://www.dropbox.com/s/rkz5iw2ovmffbn5/iOS_With_NFC.png?dl=0 |
Zeplin: Android: https://zpl.io/awxPyyg |
Just noticed that it should be "pairing with a two-factor...". Changed it on Lokalise. |
@DmitryBespalov @elgatovital fyi ☝️ |
@tschubotz will be done |
Corrected: Android: https://zpl.io/awxPyyg I archived flows with Authenticator on zeplin. It is only possible to connect it during recovery. |
Please see epic for details.
What do we do when no 2FA is available (i.e. the phone doesn't have NFC)?
The text was updated successfully, but these errors were encountered: