New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support batch transactions #271

Closed

tschubotz opened this issue Nov 12, 2019 · 5 comments

Member

tschubotz commented Nov 12, 2019

Please see epic for details.

We need to think about:

How do we let the user know that a transaction contains mulitple ones?
Can they examine the single transcations in detail?

tschubotz added the design label

posthnikova commented Dec 6, 2019

Designs for iOS: https://invis.io/3ER8F3INR48

What's been done:

Review screen with 2FA required https://invis.io/3ER8F3INR48#/396680655_Send_Review2FARequired_-Batch-_
List of individual transactions https://invis.io/3ER8F3INR48#/396680648_Batched_Transactions_List_
Review screen when there are 0 transactions https://invis.io/3ER8F3INR48#/396680652_Send_Review2FARequired_-Batch_-_0_Transactions-_
Insufficient funds https://invis.io/3ER8F3INR48#/396680654_Send_Review2FARequired_-Batch_-_Insufficient_Funds-_
2FA confirmed
Review screen without 2FA
Overview transactions
Transaction details (success, pending, failed)

elgatovital commented Dec 6, 2019

batched transaction with 0 transactions inside looks confusing

posthnikova commented Dec 10, 2019

Small text changes and Android.

iOS: https://invis.io/3ER8F3INR48

Android: https://invis.io/TWS723THG6N

batched transaction with 0 transactions inside looks confusing

@elgatovital Could you please elaborate on what is confusing? The phrase "0 transactions inside"?

posthnikova commented Dec 12, 2019

UX sync:
This performs 3 transactions.

posthnikova commented Dec 12, 2019 •

edited

Loading

Zeplin:

iOS: https://app.zeplin.io/project/5c49ce9866e3b3bee966f431/dashboard?seid=5df266d345b55fa54d3a400c

Android: https://app.zeplin.io/project/5af063c9b4dc859b6bdaf897/dashboard?seid=5df265e8eb30dcaf81561282

tschubotz closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment