Monitor process crashes occasionally with SIGSEGV when closing terminal with Ctrl+D #1092
Comments
|
Thanks for reporting this, if you can get a backtrace in gdb that would be awesome. |
|
Here is the output of (gdb) bt full |
|
Thanks, I'll have a look over the weekend. |
|
Unfortunately I'm not able to reproduce this on Arch. Looking at the stack trace it looks like it is failing when calling the Destroy callback, likely the Terminal one. I don't see anything obviously wrong with it. What D compiler and version are you using, I've had some oddities with older versions of LDC in the past. |
|
I am using dmd 2.073. As I said, I am not able to reproduce this behavior myself each time but this is happening only since I use 1.6.5 and GtkD 3.6.6. |
|
I have been using tilix pretty much 24/7 as I'm working on some ansible scripts and I had a couple of core dumps during that time so really need to track this down before doing a release. One thing I wonder if it is related to DMD, I've rebuilt my local instance with LDC and testing that out now. |
|
Thanks for testing that. I work with openSUSE Leap, which is a conservative and stable release, so I am sure that neither Gtk libs nor dmd versions have changed. My build are all made the same way through the Open Build Service which use the same virtual build environment. EDIT: I will rebuild master against GtkD 3.6.5 and see what happen. |
|
Version 3.6.6 fixed a memory leak in GtkD, so what we are experiencing now is likely an issue related to certain objects (terminal, VTE and session) being properly freed. The other change I made is to enable the process monitoring by default. While I don't see anything in the traces related to that, you could try disabling it by changing I really appreciate your patience with this, I'll spend some time over the weekend digging into it as well. |
|
You're welcome, Tilix is such a good terminal, it helps me saving a lot of time in my workflow, so if I can humbly help to make it better, I more than happy to do so. |
|
Hi, |
|
Hi, I will try another build with GtkD-3.6.6 with process monitoring disabled as you suggested before. |
|
I'm not sure what the issue is, however I just got a core dump in the process monitor so I'm going to try disabling that. Because the process monitor is multi-threaded, it's possible it's causing these random issues. |
|
@sogalboogalsky Have things been stable for you since disabling the process monitor? I haven't had any issues on my end since I made that change and I have checked in a change to disable it by default. |
|
No problem since my last post and rebuild without process monitor. But I haven't used my office computer the last two days, so I am not able to fully confirm that. So far so good but I will keep testing it during a couple of days and let you know. |
|
After a few more days using this version (compiled without process monitor and against GtkD-3.6.6) things have been stable. |
|
I'll work on bringing it back and will leave this issue open until I do, it's just good to know where the issue is coming from. I likely won't get too it though until after the next release as I've been postponing it until this issue is resolved. |
gnunn1
changed the title
|
I've been using this functionality for the last week or so and haven't noticed any issues with crashes. I suspect part of the issue may have been memory issues with GtkD as there was a period of time where you run into some once in a blue moon issues. However I'm reluctant to mainstream it just yet without more people trying it which won't happen at the moment unless as it's hidden behind a compile switch. In order to move things forward I have added a new command flag, In order to activate this functionality, the flag must be included the first time you run tilix because the monitoring happens across all instances. If you do not enable the command line flag but use the process variable in the title it will report "Not Enabled". I debated about hiding the variable when the flag is disabled but wanted to encourage people to try it out. Please do let me know if there are any issues with it. Thanks to @s4n-gt for their work on this as well, sorry it took so long for me to get back to it. |
|
Hi, |
|
Note I've changed it to a hidden dconf setting instead of a command line switch, the cli switch was painful to deal with when using desktop files. |
Hi,
I experienced this 2 times only in 4 days with Tilix 1.6.5 build from master (to test tabs implementation).
OS : openSUSE Leap 42.3
VTE : 0.44
GTK version : 3.20.10
No Tilix special features
When closing a terminal with Ctrl + D, the whole Tilix window (and app) crashes. It does not happened all the time.
sudo coredumpctl gdbprovides the following output:
I have rebuild Tilix with debug symbols so I'll be able to provide more detailed output next time it happens.
Regards.
The text was updated successfully, but these errors were encountered: