Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Websockets #15

Closed
utrack opened this issue Nov 9, 2015 · 1 comment
Closed

Websockets #15

utrack opened this issue Nov 9, 2015 · 1 comment

Comments

@utrack
Copy link

utrack commented Nov 9, 2015

Hi! Not sure what's going on, but it seems that gorilla websockets (and native ones by the looks of it) aren't compatible with writers supplied by Chi.

    hijacker, ok := w.(http.Hijacker)
    if !ok {
        return nil, nil, errors.New("the ResponseWriter doesn't support the Hijacker interface")
    }
    return hijacker.Hijack()

Hijack method here returns http: Hijack is incompatible with use of CloseNotifier error (https://golang.org/src/net/http/server.go#L154)

@utrack
Copy link
Author

utrack commented Nov 9, 2015

Nevermind, forgot I was using CloseNotify middleware somewhere else.

@utrack utrack closed this as completed Nov 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant