Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible bug can lead to security issue #886

Closed
lfama opened this issue Dec 18, 2023 · 4 comments
Closed

Possible bug can lead to security issue #886

lfama opened this issue Dec 18, 2023 · 4 comments

Comments

@lfama
Copy link

lfama commented Dec 18, 2023

Hi there,

I believe I found a bug that can lead to a security issue in some scenarios. I've noticed that the repository doesn't have a Security policy, so I'm not sure how to report it. Could you please let me know which is the right channel to report the issue?

Thanks!

@lfama
Copy link
Author

lfama commented Dec 18, 2023

Hi @pkieltyka, it looks like I can't DM you on X/Twitter

@pkieltyka
Copy link
Member

@lfama I opened my DMs, can you try again?

@pkieltyka
Copy link
Member

peterk -- github may have auto-tagged you, can you click the "unsubscribe" button? I'm not aware of any other way to untag you

@pkieltyka
Copy link
Member

thank you @lfama for the report. Feel free to add any additional details to this ticket if you'd like too :)

@lfama had found an issue which was introduced from the community PR #776. The faulty behaviour was that the "Allow" header on 405 responses and was not properly reset in the request context between requests, which are reused via a sync.Pool -- as a result, the "Allow" header was returned and repeated multiple times to clients.

The fix is: 9dd8b4a to reset the buffer before using the context.

I've published a new release v5.0.11, https://github.com/go-chi/chi/releases/tag/v5.0.11

Thanks again @lfama 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants