Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log with a custom logger instead of the slog.DefaultHandler #2

Closed
EwenQuim opened this issue Oct 20, 2023 · 2 comments · Fixed by #9
Closed

Log with a custom logger instead of the slog.DefaultHandler #2

EwenQuim opened this issue Oct 20, 2023 · 2 comments · Fixed by #9
Labels
enhancement New feature or request
Milestone
v0.10

Comments

@EwenQuim
Copy link
Member

EwenQuim commented Oct 20, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.
I want to use my own logger.

Describe the solution you'd like
An option in the app declaration, of type slog.Handler. It must default to the slog.DefaultHandler.

All calls to slog.Info/Debug etc... Must be rewritten to s.log.Info, s being the *Server instance
@EwenQuim EwenQuim added the enhancement New feature or request label Oct 20, 2023
@EwenQuim EwenQuim mentioned this issue Oct 20, 2023
Closed
@EwenQuim EwenQuim added this to the v1.0 milestone Oct 20, 2023
@nhAnik
Copy link
Contributor

nhAnik commented Oct 20, 2023

Hi @EwenQuim, can I work on this?

@EwenQuim
Copy link
Member Author

EwenQuim commented Oct 20, 2023 •
edited
Loading

Yes of course, contributions are welcome ! 🙏🏼

@nhAnik nhAnik mentioned this issue Oct 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Roadmap Fuego 🔥
Status: Done
Milestone
v0.10
Development

Successfully merging a pull request may close this issue.

Added option for custom logger nhAnik/op
2 participants
@nhAnik @EwenQuim