Skip to content
This repository has been archived by the owner on Jul 12, 2019. It is now read-only.

Add draft blog post for 1.4.0 release #54

Merged
merged 16 commits into from
Mar 25, 2018
Merged

Add draft blog post for 1.4.0 release #54

merged 16 commits into from
Mar 25, 2018

Conversation

thehowl
Copy link
Contributor

@thehowl thehowl commented Jan 12, 2018

Still a draft, and with many parts left to do still. What do you think?

Rendered markdown can be seen here: https://github.com/thehowl/blog-1/blob/release-1.4.0/content/post/release-of-1.4.0.md (without images, though)

cc/ @lafriks, as we were discussing this yesterday.

@strk
Copy link
Member

strk commented Jan 12, 2018

I love it !
Ideally also the CHANGELOG.md would only contain notable changes, will you also help with that ?

LGTM

Owners: make this guy a release manager!

Copy link
Member

@appleboy appleboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome.

Copy link
Member

@lafriks lafriks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not merge before actual release ;)

@thehowl
Copy link
Contributor Author

thehowl commented Jan 12, 2018

@strk Possibly. I won't do that retroactively (hell no I'm not working through another 1500 merged PRs), but I think I could probably just copy the "Other changes" section, remove any jokes, and add the release highlights in a compacted form, while on top linking to the blog post.

@strk
Copy link
Member

strk commented Jan 12, 2018

Are merge styles not in?

@lafriks
Copy link
Member

lafriks commented Jan 12, 2018

These also would be nice to mention:
go-gitea/gitea#3225 (deploy keys with write support)
go-gitea/gitea#3188 (PR squash&merge, rebase&merge support)
go-gitea/gitea#2938 (LFS locking support)

@ShalokShalom
Copy link

If I commit today/very soon updates on the translations, would they get included?

Thanks a lot

@lafriks
Copy link
Member

lafriks commented Jan 12, 2018

@ShalokShalom if you mean gitea web UI translations than yes, there is still time for that

@ShalokShalom
Copy link

ShalokShalom commented Jan 12, 2018

Fine, thanks a lot.

The current translation is officially finished, while important parts of the GUI are still in English.

I guess the maintainer thinks its fine to leave them untranslated since some persons are used to English terms.

I for myself think that these translations could be done.
This 'one part in English and one part in another language' thing confuses me and it undermines the sense of a translation.

People who want to have an English UI can use the English UI.

I like to ask for approval before I so this job.

@lafriks
Copy link
Member

lafriks commented Jan 12, 2018

@ShalokShalom what language are you talking about? :)

@ShalokShalom
Copy link

German

@ShalokShalom
Copy link

And in general - this counts for every language, so we might find a conclusion here for all of them. :)

@lafriks
Copy link
Member

lafriks commented Jan 12, 2018

@ShalokShalom this is not the place to discuss that. Please use #translations channel

@bkcsoft
Copy link
Member

bkcsoft commented Jan 12, 2018

Def. love it! 😍 I vote that @thehowl writes all our future release posts :trollface:

@thehowl
Copy link
Contributor Author

thehowl commented Jan 12, 2018

@lafriks Thanks, mentioned them all. Also added a list of all the contributors to the release, which reminded me of how bad I am at writing python.

@ShalokShalom
Copy link

That squash and merge support is awesome: Will there be a short screencast to demonstrate its usage?

@lafriks
Copy link
Member

lafriks commented Jan 12, 2018

@ShalokShalom there are screenshots in PR, otherwise it's quite close to how it looks and works in github

@tboerger
Copy link
Member

Nice post, but the thanks list is not really correct :)

@lafriks
Copy link
Member

lafriks commented Jan 12, 2018

@ShalokShalom something must be wrong with your script, even as two my PR are featured, I'm not in contributors list :)

@ShalokShalom
Copy link

Its not my script ;)

@thehowl
Copy link
Contributor Author

thehowl commented Jan 12, 2018

@lafriks There was an issue with the script; it only really fetched from the GitHub API open pull requests (because apparently, creating status=merged and putting the milestone parameter also for the pull request API was too hard for them 🙄). It's fixed now :)

@appleboy appleboy changed the title Add draft blog post for 1.4.0 release [WIP] Add draft blog post for 1.4.0 release Jan 13, 2018
Copy link

@ShalokShalom ShalokShalom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome ^-^

Copy link
Member

@bkcsoft bkcsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few suggestions. If you don't have time just 👍 and I'll make them myself :)


![Responsive UI screenshot](/demos/2750/3.png)

Starting from version 1.4.0, Gitea's web interface is finally responsive; this means it can be properly used from your phone without having to pinch everywhere to see what is on the screen! There may be some places where the interface is still not completely responsive, in which case we ask you kindly to [file an issue](https://github.com/go-gitea/gitea/issues) if there isn't one already, posting screenshots of what does not work.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"finally responsive" suggests that we'll keep it a priority to make sure it stays taht way. AFAIK we don't have any tests that checks the frontend right? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we don't really have those. (If someone is willing to do them, I'll be glad. I can bear writing unit tests for Go, definitely not writing tests for the frontend). So what do you suggest?

Copy link

@ShalokShalom ShalokShalom Jan 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might prefer property testing.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thehowl I'd suggest something like "Starting from version 1.4.0, we've reworked some of the interface to allow for a more responsive design" maybe? 🤔

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With some examples?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShalokShalom examples would be great but not necessarily


![Screenshot of Reactions](/demos/2856/2.png)

Yes. Yes! YES!!! Gitea now has reactions on pull requests and issues. Now hopefully your collaborators will shut up with their "+1" comments on the issue and will instead just press the 👍 button. Oh yeah 😎.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe not telling collaborators to "shut up" 😂 How about Maybe now your inbox will not be filled with "+1" emails instead. Still tounge-in-cheek, while not offending your collaborators 😉


![Progress bar demo](/demos/3171/1.png)

Did you know that Gitea has, like GitHub, support for checkboxes in markdown? If you write a bulletpoint in the following format: `- [ ]` you will get a nice HTML textbox. And does this have to do with checkboxes? Everything, of course! The issue list will now show the percentage of checked items in the top issue post. So you always know how far you've gotten on the roadmap.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"does this" => "what does this" 🙂


![Commit body expansion demo](/demos/2980/1.gif)

Making a long commit? Now you can view the entire contents of it without changing the page; you will only need to press on the ellipsis button, similar to what you can see on GitHub and GitLab.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making a long commit sounds like you put a lot of changes in it. Maybe Did someone write an entire essay in the commit message? 😄


# Other changes

- **BREAKING:** if you used `GOGS_WORK_DIR` to change the working directory of Gitea, that won't work anymore - you'll need to use `GITEA_WORK_DIR`. ([#2946](https://github.com/go-gitea/gitea/pull/2946))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I very much think we should have all breaking changes at the top. Otherwise people will miss them (who reads changelogs anyway? :trollface: )

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wdym by at the top? at the top of the article? or is there some sarcasm I didn't catch? :P

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the top of the article.

- If you're a [Dingtalk](https://www.dingtalk.com/en) user, you'll be happy to know webhooks now support it starting from 1.4.0. Hooray! ([#2777](https://github.com/go-gitea/gitea/pull/2777))
- As a reminder, we currently support webhooks for Slack, Discord and Gitea's own format, as well as a version for Gogs, to keep backwards compatibility. Also, Gitea and Gogs are mostly compatible with GitHub's webhooks!
- Git LFS aficionados: we added support for the [File Locking API](https://github.com/git-lfs/git-lfs/blob/master/docs/api/locking.md). ([#2938](https://github.com/go-gitea/gitea/pull/2938))
- Parlez-vous français? The Gitea docs now features [French](https://docs.gitea.io/fr-fr/). Keep in mind that the only language that is guaranteed to be kept up-to-date on the documentation is English; all other languages may have information that is inaccurate, so please stick to english if you want to make sure everything works in the latest gitea version. ([#3030](https://github.com/go-gitea/gitea/pull/3030))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"now also in [French]" ?

@thehowl
Copy link
Contributor Author

thehowl commented Jan 30, 2018

@bkcsoft can you address my questions?

I've finished it up - it's now ready for the final reviews. I'd say we wait this to be merged after the release candidates.

@thehowl thehowl changed the title [WIP] Add draft blog post for 1.4.0 release Add draft blog post for 1.4.0 release Jan 30, 2018
@thehowl
Copy link
Contributor Author

thehowl commented Feb 16, 2018

@bkcsoft sorry for the absence - addressed the issue

@bugreport0
Copy link

bugreport0 commented Mar 3, 2018

@thehowl asked me if I could take a look. It's great work. The tone was a bit over-excited so I tried to focus more on the features, which are impressive as is! Here's my PR: https://github.com/thehowl/blog-1/pull/1

@ShalokShalom
Copy link

The over excited bits and pieces were the most exciting parts on this release announcement to me and others ;)

1 similar comment
@ShalokShalom
Copy link

The over excited bits and pieces were the most exciting parts on this release announcement to me and others ;)

@bugreport0
Copy link

@ShalokShalom I tried to keep the tone professional and consistent with the style I use for the English translation.

I think it's perfect and awesome for you and all others to be over-excited and proud about these features as developers and contributors to Gitea. As I wrote earlier, it's an amazing development tool!

But I think (just my opinion) that projecting a clean, professional image outwards lowers the barrier of entry to people who don't know Gitea or its internals. Don't show people where we've been, show them where we're at right now.

Also, I just randomly dropped into Gitea and started editing and writing stuff. Everyone is free to ignore me and my suggestions. I don't have any claim to power or authority!

@lafriks
Copy link
Member

lafriks commented Mar 25, 2018

Make LG-TM work

@lafriks lafriks merged commit 68830a8 into go-gitea:master Mar 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants