-
Notifications
You must be signed in to change notification settings - Fork 42
Conversation
repo_commit.go
Outdated
@@ -9,6 +9,7 @@ import ( | |||
"container/list" | |||
"strconv" | |||
"strings" | |||
"github.com/mcuadros/go-version" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix import order.
@JonasFranzDEV Actually it is not in |
@@ -0,0 +1,33 @@ | |||
package git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment header
repo_commit_test.go
Outdated
"testing" | ||
|
||
"github.com/stretchr/testify/assert" | ||
"path/filepath" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import order
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please check my last comments.
maybe test different git version via .drone.yml? |
@lunny Shouldn't drone already run tests for latest git and git 1.7? |
@daviian Yes, there are already two git versions. LGTM |
Targets go-gitea/gitea#3458
Should fix
commitsBefore
for older git versions.