Skip to content
This repository has been archived by the owner on Apr 12, 2019. It is now read-only.

Fixed a bug where TreeEntries were getting cached, (thanks @filipnavara) #139

Merged
merged 1 commit into from Jan 16, 2019

Conversation

Kasi-R
Copy link

@Kasi-R Kasi-R commented Jan 8, 2019

Fixes the bug described at #123 (comment)

@codecov-io
Copy link

codecov-io commented Jan 8, 2019

Codecov Report

Merging #139 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #139   +/-   ##
=======================================
  Coverage   32.46%   32.46%           
=======================================
  Files          28       28           
  Lines        1814     1814           
=======================================
  Hits          589      589           
  Misses       1148     1148           
  Partials       77       77
Impacted Files Coverage Δ
tree.go 53.06% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c811eb4...241f254. Read the comment docs.

@filipnavara
Copy link

filipnavara commented Jan 8, 2019

On second thought, the entriesRecursiveParsed and entriesParsed variables are actually never set. Either that should be fixed too, or the cache can be removed entirely (since it was never working anyway).

Sorry, should have noticed that earlier, but I was blindly following the code when updating my forked code base.

@Kasi-R
Copy link
Author

Kasi-R commented Jan 8, 2019

I guess i can add the caching check to both functions.

Edit: Updated the caching flag. Squashed the two commits.

@lunny lunny merged commit 7d7fe9f into go-gitea:master Jan 16, 2019
@lunny
Copy link
Member

lunny commented Jan 16, 2019

Please send a upgrade PR to go-gitea/gitea

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants