Skip to content
This repository has been archived by the owner on Apr 12, 2019. It is now read-only.

get branch commit belongs to #142

Merged
merged 1 commit into from
Feb 3, 2019
Merged

get branch commit belongs to #142

merged 1 commit into from
Feb 3, 2019

Conversation

adelowo
Copy link
Member

@adelowo adelowo commented Feb 3, 2019

This allows us to get the branch a commit belongs to.

If commit oooo is on master and a_feature_branch, it defaults to master as the result. I have gone through GitHub's implementation and it is the same. Here is an example, go-gitea/gitea@7cb1d82 exists on master and release/v1.7 but it defaults to showing master

Needed to fix go-gitea/gitea#5473

@codecov-io
Copy link

codecov-io commented Feb 3, 2019

Codecov Report

Merging #142 into master will increase coverage by 0.05%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #142      +/-   ##
==========================================
+ Coverage   33.71%   33.76%   +0.05%     
==========================================
  Files          28       28              
  Lines        1827     1833       +6     
==========================================
+ Hits          616      619       +3     
- Misses       1132     1134       +2     
- Partials       79       80       +1
Impacted Files Coverage Δ
commit.go 10.94% <ø> (ø) ⬆️
repo_commit.go 25.28% <50%> (+0.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d04f81a...de805d0. Read the comment docs.

@zeripath zeripath merged commit fbe468c into go-gitea:master Feb 3, 2019
@lunny
Copy link
Member

lunny commented Feb 4, 2019

Why not we give more than one branch? Maybe it's better than github and almost have the same performance.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display the branch name in the commit view
6 participants