Skip to content

Commit

Permalink
Add fullTextSearch to dropdowns by default (#14694)
Browse files Browse the repository at this point in the history
This PR adds `fullTextSearch: 'exact'` to most dropdown
invocations meaning that if there is a search box for the
dropdown it will automatically do a fullTextSearch looking
for the provided fragment instead of starting at the beginning

We should consider changing other places that use
`fullTextSearch: true` to `'exact'` because these will be using a
fuzzy-textual search that doesn't necessarily return the
expected results.

Fix #14689

Signed-off-by: Andrew Thornton <art27@cantab.net>
  • Loading branch information
zeripath committed Feb 16, 2021
1 parent 0a9a484 commit 60ef2a7
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 4 deletions.
1 change: 1 addition & 0 deletions web_src/js/features/gitgraph.js
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ export default async function initGitGraph() {
$('#flow-select-refs-dropdown').dropdown('set selected', dropdownSelected);
$('#flow-select-refs-dropdown').dropdown({
clearable: true,
fullTextSeach: 'exact',
onRemove(toRemove) {
if (toRemove === '...flow-hide-pr-refs') {
params.delete('hide-pr-refs');
Expand Down
14 changes: 10 additions & 4 deletions web_src/js/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -2408,18 +2408,23 @@ $(document).ready(async () => {
});

// Semantic UI modules.
$('.dropdown:not(.custom)').dropdown();
$('.dropdown:not(.custom)').dropdown({
fullTextSearch: 'exact'
});
$('.jump.dropdown').dropdown({
action: 'hide',
onShow() {
$('.poping.up').popup('hide');
}
},
fullTextSearch: 'exact'
});
$('.slide.up.dropdown').dropdown({
transition: 'slide up'
transition: 'slide up',
fullTextSearch: 'exact'
});
$('.upward.dropdown').dropdown({
direction: 'upward'
direction: 'upward',
fullTextSearch: 'exact'
});
$('.ui.accordion').accordion();
$('.ui.checkbox').checkbox();
Expand Down Expand Up @@ -3465,6 +3470,7 @@ function initTopicbar() {
topicDropdown.dropdown({
allowAdditions: true,
forceSelection: false,
fullTextSearch: 'exact',
fields: {name: 'description', value: 'data-value'},
saveRemoteData: false,
label: {
Expand Down

0 comments on commit 60ef2a7

Please sign in to comment.