Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

full-text search doesn't work in fields with branches while editing pull request #14689

Closed
1 of 6 tasks
lakostin opened this issue Feb 15, 2021 · 0 comments · Fixed by #14694
Closed
1 of 6 tasks

full-text search doesn't work in fields with branches while editing pull request #14689

lakostin opened this issue Feb 15, 2021 · 0 comments · Fixed by #14694
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@lakostin
Copy link

  • Gitea version (or commit ref):
    1.14.0+dev-534-gedbc5c86d
  • Git version:
    2.26.2
  • Operating system:
    docker Alpine Linux v3.12
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
  • Log gist:

Description

If i want to change target or source branch in already created pull request, i have to write the name of new branch starting from organization. If i type just branch name it won't be found.
...

Screenshots

Screenshot from 2021-02-15 18-15-13
Screenshot from 2021-02-15 18-14-55
@lunny lunny added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Feb 15, 2021
zeripath added a commit to zeripath/gitea that referenced this issue Feb 15, 2021
@zeripath
Add fullTextSearch to dropdowns by default
5816f0c 
This PR adds `fullTextSearch: 'exact'` to most dropdown
invocations meaning that if there is a search box for the
dropdown it will automatically do a fullTextSearch looking
for the provided fragment instead of starting at the beginning

We should consider changing other places that use
`fullTextSearch: true` to `'exact'` because these will be using a
fuzzy-textual search that doesn't necessarily return the
expected results.

Fix go-gitea#14689

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath mentioned this issue Feb 15, 2021
Merged
lunny pushed a commit that referenced this issue Feb 16, 2021
@zeripath
Add fullTextSearch to dropdowns by default (#14694)
60ef2a7 
This PR adds `fullTextSearch: 'exact'` to most dropdown
invocations meaning that if there is a search box for the
dropdown it will automatically do a fullTextSearch looking
for the provided fragment instead of starting at the beginning

We should consider changing other places that use
`fullTextSearch: true` to `'exact'` because these will be using a
fuzzy-textual search that doesn't necessarily return the
expected results.

Fix #14689

Signed-off-by: Andrew Thornton <art27@cantab.net>
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add fullTextSearch to dropdowns by default zeripath/gitea
2 participants
@lunny @lakostin