-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add auto logging of goroutine pid label (#19212)
* Add auto logging of goroutine pid label This PR uses unsafe to export the hidden runtime_getProfLabel function from the runtime package and then casts the result to a map[string]string. We can then interrogate this map to get the pid label from the goroutine allowing us to log it with any logging request. Reference #19202 Signed-off-by: Andrew Thornton <art27@cantab.net>
- Loading branch information
Showing
3 changed files
with
61 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
// Copyright 2022 The Gitea Authors. All rights reserved. | ||
// Use of this source code is governed by a MIT-style | ||
// license that can be found in the LICENSE file. | ||
|
||
package log | ||
|
||
import "unsafe" | ||
|
||
//go:linkname runtime_getProfLabel runtime/pprof.runtime_getProfLabel | ||
func runtime_getProfLabel() unsafe.Pointer // nolint | ||
|
||
type labelMap map[string]string | ||
|
||
func getGoroutineLabels() map[string]string { | ||
l := (*labelMap)(runtime_getProfLabel()) | ||
if l == nil { | ||
return nil | ||
} | ||
return *l | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
// Copyright 2022 The Gitea Authors. All rights reserved. | ||
// Use of this source code is governed by a MIT-style | ||
// license that can be found in the LICENSE file. | ||
|
||
package log | ||
|
||
import ( | ||
"context" | ||
"runtime/pprof" | ||
"testing" | ||
|
||
"github.com/stretchr/testify/assert" | ||
) | ||
|
||
func Test_getGoroutineLabels(t *testing.T) { | ||
pprof.Do(context.Background(), pprof.Labels(), func(ctx context.Context) { | ||
currentLabels := getGoroutineLabels() | ||
pprof.ForLabels(ctx, func(key, value string) bool { | ||
assert.EqualValues(t, value, currentLabels[key]) | ||
return true | ||
}) | ||
|
||
pprof.Do(ctx, pprof.Labels("Test_getGoroutineLabels", "Test_getGoroutineLabels_child1"), func(ctx context.Context) { | ||
currentLabels := getGoroutineLabels() | ||
pprof.ForLabels(ctx, func(key, value string) bool { | ||
assert.EqualValues(t, value, currentLabels[key]) | ||
return true | ||
}) | ||
if assert.NotNil(t, currentLabels) { | ||
assert.EqualValues(t, "Test_getGoroutineLabels_child1", currentLabels["Test_getGoroutineLabels"]) | ||
} | ||
}) | ||
}) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters