Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weird left shift on system notices #10569

Closed
alexanderadam opened this issue Mar 2, 2020 · 4 comments · Fixed by #10576
Closed

Weird left shift on system notices #10569

alexanderadam opened this issue Mar 2, 2020 · 4 comments · Fixed by #10576
Labels
topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile type/bug
Milestone
1.12.0

Comments

@alexanderadam
Copy link

alexanderadam commented Mar 2, 2020 •
edited
Loading

  • Gitea version (or commit ref): 1.12.0+dev-412-g4160bd6ef

Description

On the system notices overview: whenever I click on this icon in the Op. column a left shift happens.

Screenshots

left_shift

UPDATE: same thing happens when I try to delete a repository
@lunny lunny added the type/bug label Mar 2, 2020
@silverwind
Copy link
Member

Can reproduce. Maybe Semantic-Org/Semantic-UI#3960 (comment), but we do load the transition module.

@silverwind
Copy link
Member

I think this is related to the fomantic-ui 2.8.4 upgrade and for some reason, fomantic-ui is not being rebuilt correctly. You should be able to solve it by doing a clean rebuild by running make clean-all and then build as usual.

@alexanderadam
Copy link
Author

I'm using the docker image. Should I call this command within the container?

@silverwind
Copy link
Member

Not sure, the image probably needs to be rebuilt.

@silverwind silverwind mentioned this issue Mar 2, 2020
Closed
7 tasks
@silverwind silverwind mentioned this issue Mar 2, 2020
Merged
@guillep2k guillep2k added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Mar 3, 2020
@guillep2k guillep2k added this to the 1.12.0 milestone Mar 3, 2020
silverwind added a commit to silverwind/gitea that referenced this issue Mar 3, 2020
@silverwind
Frontend build improvements, hopefully fix Fomantic build
16d32ad 
- add package-lock.json to webpack/fomantic prereqs making them always rebuild when dependencies change.
- remove FOMANTIC_EVIDENCE. It seemed better to just track a few output files instead.
- delete fomantic output files before build to prevent possible bugs in fomantic's build.
- resolve WEBPACK_SOURCES only once for performance
- reorder variables for clarity
- use clean-all in Dockerfile
- detect busybox for find syntax

Fixes: go-gitea#10569
Fixes: go-gitea#10565
Fixes: go-gitea#10570
Fixes: go-gitea#10568
jolheiser pushed a commit that referenced this issue Mar 3, 2020
@silverwind
Frontend build improvements, fix Fomantic build (#10576)
fa6ea60 
- add package-lock.json to webpack/fomantic prereqs making them always rebuild when dependencies change.
- remove FOMANTIC_EVIDENCE. It seemed better to just track a few output files instead.
- delete fomantic output files before build to prevent possible bugs in fomantic's build.
- resolve WEBPACK_SOURCES only once for performance
- reorder variables for clarity
- use clean-all in Dockerfile
- detect busybox for find syntax

Fixes: #10569
Fixes: #10565
Fixes: #10570
Fixes: #10568
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile type/bug
Projects
None yet
Milestone
1.12.0
Development

Successfully merging a pull request may close this issue.

Frontend build improvements, hopefully fix Fomantic build silverwind/gitea
4 participants
@lunny @silverwind @alexanderadam @guillep2k