Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: protected branch: pull check #10636

Closed
6543 opened this issue Mar 6, 2020 · 6 comments · Fixed by #10648 or #11074
Closed

bug: protected branch: pull check #10636

6543 opened this issue Mar 6, 2020 · 6 comments · Fixed by #10648 or #11074
Labels
type/bug
Milestone
1.11.5

Comments

@6543
Copy link
Member

6543 commented Mar 6, 2020

Gitea version: 1.12.0+dev-447-g123d38605

if you enable branch protection and leave all default beside "Enable Status Check" the pull merge-status is considderted as not mergable! (only force mergable via admin rights)

to reproduce:
A: enable branch protection
B: enable Status Check **with: no status checks found in the last week ..."

result:

  • user with write access:
    Bildschirmfoto zu 2020-03-06 13-57-23

  • user with admin access:
    Bildschirmfoto zu 2020-03-06 13-57-55
@6543
Copy link
Member Author

6543 commented Mar 6, 2020

solution: either dont let status checks enable if there is no one or fix pull-check-mergable function

@lunny lunny added the type/bug label Mar 6, 2020
@lunny lunny mentioned this issue Mar 7, 2020
Merged
@lunny lunny added this to the 1.11.3 milestone Mar 7, 2020
@6543
Copy link
Member Author

6543 commented Mar 7, 2020 •
edited

#10648 didnt close this!

EDIT: just follow steps to reproduce!

@6543
Copy link
Member Author

6543 commented Mar 7, 2020

you need 2 users.

  1. Create a new repo (initialized)
  2. change readme to new branch & open a pull request
  3. add user2 to repo as colaborator with write permission
  4. enable branch protection for master & set "Enable Status Check"
  5. view pull with user2 you will see this:

Bildschirmfoto zu 2020-03-07 22-16-46

@zeripath zeripath reopened this Mar 7, 2020
@lunny
Copy link
Member

lunny commented Mar 10, 2020

Is this a UI problem?

@lunny lunny modified the milestones: 1.11.3, 1.11.4 Mar 10, 2020
@6543
Copy link
Member Author

6543 commented Mar 11, 2020

look's like one - there is NO server error

@lafriks lafriks modified the milestones: 1.11.4, 1.11.5 Apr 1, 2020
@6543
Copy link
Member Author

6543 commented Apr 14, 2020

stil here :(

@6543 6543 mentioned this issue Apr 14, 2020
Merged
zeripath pushed a commit that referenced this issue Apr 15, 2020
@6543
Fix merge dialog on protected branch with missing required statuses (#…
a88f366 
…11074)

It is possible for misconfigured protected branches to have required status checks that are not in any of the current statuses: Pending, Success, Error, Failure, or Warning - presumably because the CI has not contacted us as yet.

Fix #10636 by adding case: missing StatusChecks when these are missing
6543 added a commit to 6543-forks/gitea that referenced this issue Apr 15, 2020
@6543
Fix merge dialog on protected branch with missing required statuses (g…
d680d6b 
…o-gitea#11074)

It is possible for misconfigured protected branches to have required status checks that are not in any of the current statuses: Pending, Success, Error, Failure, or Warning - presumably because the CI has not contacted us as yet.

Fix go-gitea#10636 by adding case: missing StatusChecks when these are missing
lafriks pushed a commit that referenced this issue Apr 16, 2020
@6543
Fix merge dialog on protected branch with missing required statuses (#…
cc2a6c1 
…11074) (#11084)

It is possible for misconfigured protected branches to have required status checks that are not in any of the current statuses: Pending, Success, Error, Failure, or Warning - presumably because the CI has not contacted us as yet.

Fix #10636 by adding case: missing StatusChecks when these are missing
ydelafollye pushed a commit to ydelafollye/gitea that referenced this issue Jul 31, 2020
@6543
Fix merge dialog on protected branch with missing required statuses (g…
22e0d17 
…o-gitea#11074)

It is possible for misconfigured protected branches to have required status checks that are not in any of the current statuses: Pending, Success, Error, Failure, or Warning - presumably because the CI has not contacted us as yet.

Fix go-gitea#10636 by adding case: missing StatusChecks when these are missing
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
1.11.5
4 participants
@lunny @lafriks @zeripath @6543