Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug on pull view when required status check no ci result #10648

Merged
merged 1 commit into from
Mar 7, 2020
Merged

Fix bug on pull view when required status check no ci result #10648

merged 1 commit into from
Mar 7, 2020

Conversation

lunny
Copy link
Member

@lunny lunny commented Mar 7, 2020

Fix #10636

@lunny lunny added this to the 1.12.0 milestone Mar 7, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 7, 2020
@codecov-io
Copy link

Codecov Report

Merging #10648 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10648      +/-   ##
==========================================
+ Coverage    43.6%    43.6%   +<.01%     
==========================================
  Files         588      588              
  Lines       82483    82488       +5     
==========================================
+ Hits        35968    35972       +4     
- Misses      42051    42053       +2     
+ Partials     4464     4463       -1
Impacted Files Coverage Δ
services/pull/commit_status.go 4.7% <0%> (-0.3%) ⬇️
services/pull/pull.go 34.7% <0%> (-1.18%) ⬇️
modules/indexer/stats/db.go 50% <0%> (ø) ⬆️
modules/git/repo.go 47.7% <0%> (+0.91%) ⬆️
modules/process/manager.go 78.31% <0%> (+3.61%) ⬆️
modules/git/utils.go 70.14% <0%> (+4.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57c7a7a...b049026. Read the comment docs.

@6543
Copy link
Member

6543 commented Mar 7, 2020

Thx, I'll lok into it tomotow

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 7, 2020
@zeripath zeripath merged commit a528189 into go-gitea:master Mar 7, 2020
@lunny lunny deleted the lunny/fix_pull_status_check branch March 7, 2020 08:29
lunny added a commit to lunny/gitea that referenced this pull request Mar 7, 2020
@lunny
Fix bug on pull view when required status check no ci result (go-gite…
44ac173 
…a#10648)
@lunny lunny mentioned this pull request Mar 7, 2020
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Mar 7, 2020
lunny added a commit that referenced this pull request Mar 7, 2020
@lunny
Fix bug on pull view when required status check no ci result (#10648) (…
7e0a5b1 
…#10651)
@6543 6543 mentioned this pull request Mar 7, 2020
Closed
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

bug: protected branch: pull check
6 participants
@lunny @codecov-io @6543 @lafriks @zeripath @GiteaBot