Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I don't think the "SKIP_VERIFY" is working for mailer settings #12117

Closed
2 of 7 tasks
donnyv opened this issue Jul 1, 2020 · 1 comment · Fixed by #12203
Closed
2 of 7 tasks

I don't think the "SKIP_VERIFY" is working for mailer settings #12117

donnyv opened this issue Jul 1, 2020 · 1 comment · Fixed by #12203

Comments

@donnyv
Copy link

donnyv commented Jul 1, 2020

  • Gitea version (or commit ref): 1.12.1 built with GNU Make 4.1, go1.14.4 : bindata, sqlite, sqlite_unlock_notify
  • Git version: 2.27.0
  • Operating system: Windows Server 2019
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:

Description

I don't think the "SKIP_VERIFY" is working. Because when I use this setup. I get an error when sending a test email.
"gomail: could not send email 1: StartTLS: x509: certificate signed by unknown authority"

[mailer]
ENABLED = true
HOST    = mail.domain.com:587
FROM    = "GiteaServer"<email@arh-us.com>
USER    = email@arh-us.com
PASSWD  = password
IS_TLS_ENABLED = false
SKIP_VERIFY = 
MAILER_TYPE = smtp

...

Screenshots
@donnyv
Copy link
Author

donnyv commented Jul 1, 2020

So s2FiRe on Discord helped me with this. Looks like SKIP_VERIFY should have a "true" for it to work. Docs says use "empty". You probably want to update that.

@cipherboy cipherboy mentioned this issue Jul 9, 2020
Merged
cipherboy added a commit to cipherboy/gitea that referenced this issue Jul 9, 2020
@cipherboy
Clarify documentation of SKIP_VERIFY
df0e7d9 
The documentation clearly documents the empty value as the default,
however at least one user reported this as being unclear. Mark values
explicitly so it is clear what values it can take. This clarifies that
an empty value in fact leaves certificate verification enabled, whereas
it has to be explicitly set to true to disable certificate verification.

Resolves: go-gitea#12117

Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
techknowlogick added a commit that referenced this issue Jul 21, 2020
@cipherboy @mrsdizzie @techknowlogick
Clarify documentation of SKIP_VERIFY (#12203)
8e20daa 
* Clarify documentation of SKIP_VERIFY

The documentation clearly documents the empty value as the default,
however at least one user reported this as being unclear. Mark values
explicitly so it is clear what values it can take. This clarifies that
an empty value in fact leaves certificate verification enabled, whereas
it has to be explicitly set to true to disable certificate verification.

Resolves: #12117

Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>

* Update docs/content/doc/advanced/config-cheat-sheet.en-us.md

Co-authored-by: mrsdizzie <info@mrsdizzie.com>

* Update custom/conf/app.example.ini

Co-authored-by: mrsdizzie <info@mrsdizzie.com>

* Update custom/conf/app.example.ini

Co-authored-by: mrsdizzie <info@mrsdizzie.com>

Co-authored-by: mrsdizzie <info@mrsdizzie.com>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clarify documentation of SKIP_VERIFY cipherboy/gitea
1 participant
@donnyv