Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with comment header display after change to flex #13316

Closed
mrsdizzie opened this issue Oct 26, 2020 · 1 comment · Fixed by #13356
Closed

Issue with comment header display after change to flex #13316

mrsdizzie opened this issue Oct 26, 2020 · 1 comment · Fixed by #13356
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Milestone
1.13.0

Comments

@mrsdizzie
Copy link
Member

Screen Shot 2020-10-26 at 10 36 47 AM

Seems to come from @kolaente PR #13039

gitea/web_src/less/_repository.less

Lines 1046 to 1047 in dbebc6b

display: flex;
justify-content: space-between;

@mrsdizzie mrsdizzie added type/bug topic/ui Change the appearance of the Gitea UI labels Oct 26, 2020
@mrsdizzie mrsdizzie added this to the 1.13.0 milestone Oct 26, 2020
@silverwind
Copy link
Member

silverwind commented Oct 26, 2020 •
edited

Probably need to put left-aligned content into it's own flexbox to prevent this, e.g. flex parent has two children, left and right-aligned which space-between then puts apart).

@silverwind silverwind mentioned this issue Oct 29, 2020
Merged
silverwind added a commit to silverwind/gitea that referenced this issue Oct 29, 2020
@silverwind
Comment Header fixes
b1f531b 
Apply more flexboxes on comment header and remove float hacks. Needs
1.13 backport.

Fixes: go-gitea#13316
lafriks added a commit that referenced this issue Oct 31, 2020
@silverwind @lafriks
Comment Header fixes (#13356)
0e6bf7e 
Apply more flexboxes on comment header and remove float hacks. Needs
1.13 backport.

Fixes: #13316

Co-authored-by: Lauris BH <lauris@nix.lv>
silverwind added a commit to silverwind/gitea that referenced this issue Oct 31, 2020
@silverwind @lafriks
Comment Header fixes (go-gitea#13356)
0c11f7c 
Apply more flexboxes on comment header and remove float hacks. Needs
1.13 backport.

Fixes: go-gitea#13316

Co-authored-by: Lauris BH <lauris@nix.lv>
techknowlogick pushed a commit that referenced this issue Oct 31, 2020
@silverwind @lafriks
Comment Header fixes (#13356) (#13374)
52b4b98 
Apply more flexboxes on comment header and remove float hacks. Needs
1.13 backport.

Fixes: #13316

Co-authored-by: Lauris BH <lauris@nix.lv>

Co-authored-by: Lauris BH <lauris@nix.lv>
@go-gitea go-gitea locked and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.13.0
Development

Successfully merging a pull request may close this issue.

Comment Header fixes silverwind/gitea
2 participants
@silverwind @mrsdizzie