Comment Header fixes #13356
Merged
Comment Header fixes #13356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silverwind
force-pushed
the
flexfix
branch
2 times, most recently
from
2c5dc32
to
12291c1
Compare
Apply more flexboxes on comment header and remove float hacks. Needs 1.13 backport. Fixes: go-gitea#13316
zeripath
approved these changes
Oct 30, 2020
GiteaBot
added
the
lgtm/need 1
lafriks
approved these changes
Oct 31, 2020
GiteaBot
added
lgtm/done
|
Please send backport |
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Oct 31, 2020
Apply more flexboxes on comment header and remove float hacks. Needs 1.13 backport. Fixes: go-gitea#13316 Co-authored-by: Lauris BH <lauris@nix.lv>
techknowlogick
pushed a commit
that referenced
this pull request
Oct 31, 2020
techknowlogick
added
the
backport/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply more flexboxes on comment header and remove float hacks. Needs 1.13 backport.
Fixes: #13316
Also, action icons are better centered. Before:
After:
@mrsdizzie please confirm, I could not test your case with more than two header children.