Fix blame line alignment #13542
Merged
Fix blame line alignment #13542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silverwind
force-pushed
the
fix-blame-wrap
branch
from
733fe65
to
748173f
Compare
We can't wrap code in blame because it's essentially two tables side-by-side which will misalign them when one line gets larger. Fixes: go-gitea#13540 Regressed by: go-gitea#13415
silverwind
force-pushed
the
fix-blame-wrap
branch
from
748173f
to
cb33fcc
Compare
GiteaBot
added
the
lgtm/need 1
|
Yeah blame is unfortunately prone to break as it's stuffing everything into three table cells that can never align with each other. It needs to be refactored to have one |
gary-kim
approved these changes
Nov 13, 2020
GiteaBot
added
lgtm/done
|
🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't wrap code in blame because it's essentially two tables side-by-side which will misalign when one line gets larger.
Fixes: #13540
Regressed by: #13415
Before:
After:
