Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit hash and commiter avatar off in the PR view #13704

Closed
4 tasks done
wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf opened this issue Nov 26, 2020 · 4 comments · Fixed by #13734
Closed
4 tasks done

Commit hash and commiter avatar off in the PR view #13704

wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf opened this issue Nov 26, 2020 · 4 comments · Fixed by #13734

Comments

@wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf
Copy link
Contributor

  • Gitea version (or commit ref): 1.14.0+dev-258-g03fa2eccb
  • Git version: git version 2.29.2.526.gbb4321173f
  • Operating system: Arch Linux
  • Built from
    • source
  • Run with
    • systemd
  • Database:
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • No

Description

Recently I have noticed this anomalously off-set commit hash+avatar labels in the PR view (see screenshots below).
Could this be somehow linked to the recent and otherwise awesome improvements brought by #13594?

Screenshots

image
image

@silverwind
Copy link
Member

Possible, those SHA boxes are currently a bit of a pain because they use like three different templates and three different CSS sections so issues like that are bound to arise eventually until they properly share template and CSS.

@CirnoT
Copy link
Contributor

CirnoT commented Nov 27, 2020

Caused by #13594 by blindly forcing display: inline on Fomantic's ui.label element. Fomantic's label element can contain additional elements (such as .detail which is used here) which breaks when inline is forced.

Since we use Fomantic and this change explicitly breaks Fomantic styling, I suppose it will have to be reverted and better solution found (refering here to w/e the display: inline attempts to do, not whole PR).

@CirnoT
Copy link
Contributor

CirnoT commented Nov 27, 2020

Additionally it seems that the .detail element is now not matching with box itself (for some reason we're using padding and margin hack there), a quick fix would be to change it to:

margin: -3px -6px -3px 0;
padding: 3px 6px 3px 6px;

however I fear this might be font-related.

Possibly removing .button .icon would work better (this removes forced padding applied by Fomantic so we don't have to work around it with hacks)?

@silverwind
Copy link
Member

silverwind commented Nov 28, 2020

That display: inline is for issue label lists only (so they wrap around and stuff), it should not match on that shabox.

silverwind added a commit to silverwind/gitea that referenced this issue Nov 28, 2020
Add common parent .labels-list to issue labels lists to prevent
affecting other elements.

Fixes: go-gitea#13704
techknowlogick pushed a commit that referenced this issue Nov 29, 2020
* Fix label styles affecting shabox

Add common parent .labels-list to issue labels lists to prevent
affecting other elements.

Fixes: #13704

* Update templates/shared/issuelist.tmpl

* Update templates/shared/issuelist.tmpl

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants