Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix label styles affecting shabox #13734

Merged
merged 4 commits into from
Nov 29, 2020
Merged

Fix label styles affecting shabox #13734

merged 4 commits into from
Nov 29, 2020

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Nov 28, 2020 •
edited
Loading

Add common parent .labels-list to issue labels lists to prevent affecting other elements.

Fixes: #13704

Screen Shot 2020-11-28 at 16 14 23

Screen Shot 2020-11-28 at 16 14 31

Screen Shot 2020-11-28 at 16 14 38

Screen Shot 2020-11-28 at 16 14 50

@silverwind
Fix label styles affecting shabox
46b253c 
Add common parent .labels-list to issue labels lists to prevent
affecting other elements.

Fixes: go-gitea#13704
@lunny lunny added the topic/ui Change the appearance of the Gitea UI label Nov 28, 2020
@lafriks lafriks added this to the 1.14.0 milestone Nov 28, 2020
@lafriks lafriks added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Nov 28, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 28, 2020
wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf
wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf approved these changes Nov 28, 2020
View reviewed changes
Copy link
Contributor

@wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

applied the patch.
fixes the issue (#13704) on my instance 🎉
thanks @zeripath

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 29, 2020
@techknowlogick
Copy link
Member

🚀

@techknowlogick techknowlogick merged commit da4bb6f into go-gitea:master Nov 29, 2020
@silverwind silverwind deleted the shabox branch November 29, 2020 07:58
@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@lafriks lafriks lafriks approved these changes

@wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.

Commit hash and commiter avatar off in the PR view
6 participants
@silverwind @techknowlogick @lunny @lafriks @wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf @GiteaBot