Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The WYSIWYG editor and preview do not work in Wiki #14196

Closed
2 of 6 tasks
SlavekB opened this issue Dec 30, 2020 · 22 comments
Closed
2 of 6 tasks

The WYSIWYG editor and preview do not work in Wiki #14196

SlavekB opened this issue Dec 30, 2020 · 22 comments

Comments

@SlavekB
Copy link

SlavekB commented Dec 30, 2020

  • Gitea version (or commit ref): 1.13.1
  • Git version: 2.20.1
  • Operating system: Debian 10.x (Buster)
  • Installed: downloaded official binary
  • Started: as systemd service
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes – wiki of any project
    • No

Description

When creating a new wiki page and opening an existing wiki page for editing, the WYSIWYG editor toolbar is not displayed there. At the same time, the preview does nothing at all.

This seems similar to issue #12971 except that the WYSIWYG editor is not displayed at all, so there is no need to switch to textarea – it doesn't work from the beginning.

@zeripath
Copy link
Contributor

I just tried this on try.gitea.io with Google Chrome | 87.0.4280.88 (Official Build) (64-bit) on ubuntu focal and it worked perfectly.

@zeripath
Copy link
Contributor

what browser are you using? if you look at the development console do you get errors etc?

@zeripath zeripath added the issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail label Dec 30, 2020
@SlavekB
Copy link
Author

SlavekB commented Dec 30, 2020

  • Palemoon 28.17
  • Firefox 68.9 (ESR)
  • Chromium 57

In Firefox, I watched the browser console, but there were no new messages.

@SlavekB
Copy link
Author

SlavekB commented Dec 30, 2020

Another test performed – another browser where it doesn't work:

  • Firefox 78.6 (ESR)

@zeripath
Copy link
Contributor

It is working on firefox 84 here

@zeripath
Copy link
Contributor

Is it possible you have cached assets?

@SlavekB
Copy link
Author

SlavekB commented Dec 30, 2020

If you mean in the browser, then I do not normally use Firefox or Chromium on my machine == these have not been running for a long time. The same goes for Firefox 78.6 on a Windows test machine. Furthermore, I only rarely go to try.gitea.io, so it doesn't seem possible that I have any old content cached there either.

@zeripath
Copy link
Contributor

have you logged in? are you certain that there no console errors? Without having a clear way to reproduce or some errors to work with we're a bit stuck.

@zeripath
Copy link
Contributor

Have you tried CTRL-F5? To forciblyreload in case you have an oldcached ServiceWorker

@SlavekB
Copy link
Author

SlavekB commented Dec 30, 2020

Another attempt – another machine where I never accessed any Gitea instance, this time Firefox 84. I assume that using a newer Firefox could be a change in that try.gitea.io works:
snimek82

But Gitea 1.13.1 still has the same problem:
snimek83

You can see an open Firefox console window in the screenshot. There is no new record at all.

@micheleCTDE
Copy link

micheleCTDE commented Dec 31, 2020

Same issue on my machine. Firefox ESR 78.6 on Debian testing. Also same issue on a Windows 10 machine with Gitea Version: 1.14.0+dev-485-g632800eda.

@vanous
Copy link

vanous commented Jan 2, 2021

Same issue here, both Firefox 84.0 (64-bit) and Chromium Version 87.0.4280.88 (Developer Build) built on Debian bullseye/sid, running on Debian bullseye/sid (64-bit), happening on Codeberg.

@mibuthu
Copy link

mibuthu commented Jan 4, 2021

I have the same problem: Gitea 1.13.1 installed via Docker, tried with multiple browsers (e.g. Firefox 84, Brave 1.18, Opera 73).
I also cannot see any error in the browser console.

@gytisrepecka
Copy link

Did you try to clear Firefox cache?

After upgrading Gitea to version 1.13.1 I had visual editor and preview gone. Perhaps some static files were cached from previous version as clearing browser cache brought editor and preview back.

@SlavekB
Copy link
Author

SlavekB commented Jan 4, 2021

As I wrote above: I used browsers that I have not used for a long time => they did not have a chance to have such data in the cache, none worked. I used latest Firefox on another virtual machine, where there had never been access to any Gitea instance before => had no chance to have such data in the cache, it worked on try.gitea.io (i.e. 1.14.0-devel), but it didn't work on our 1.13.1.

@BLumia
Copy link
Member

BLumia commented Jan 5, 2021

I also have this issue on my selfhosted gitea 1.13.1 instance, the issue will be gone if I switch back to 1.13.0. Either 1.13.0 or the try.gitea.io instance (with version 1.14.0+dev-506-g126c9331d) doesn't have this issue. Use 1.13.1 with a clean installed firefox browser also wont fix this issue.

I found there was a commit between 1.13.0 and 1.13.1 that most likely related to this issue, which will try not use simpleMDE editor on mobile devices for 1.13 (4f296f7). simply revert that commit seems fixes this issue (at least on my machine).

Let me know if you need any other information.

@lunny lunny added type/bug and removed issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail labels Jan 5, 2021
@lunny lunny added this to the 1.13.2 milestone Jan 5, 2021
@lunny
Copy link
Member

lunny commented Jan 5, 2021

I can confirm this is a bug and should be fixed on v1.13.2

@miklobit
Copy link

miklobit commented Jan 9, 2021

I have the same problem: Gitea 1.13.1 installed via Docker, tried with multiple browsers (e.g. Firefox 84, Brave 1.18, Opera 73).
I also cannot see any error in the browser console.

Same with me. Fresh installation with docker image gitea/gitea:1.13.1

@ojn
Copy link

ojn commented Jan 20, 2021

Same, on Gitea 1.13.1 using Firefox 84.0.2 and Chromium 87.0

@trepmag
Copy link

trepmag commented Jan 25, 2021

Do someone have a quick turn around for 1.13.1 docker until 1.13.2?

@lunny
Copy link
Member

lunny commented Jan 25, 2021

I think we can just remove the preview tab because there is already a preview button on the toobar.

@jpraet
Copy link
Member

jpraet commented Jan 28, 2021

I think the issue is here: https://github.com/go-gitea/gitea/blob/release/v1.13/web_src/js/index.js#L1362

should be isMobile()

@lunny lunny closed this as completed Jan 29, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.